You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by "Lewis John McGibbney (JIRA)" <ji...@apache.org> on 2012/05/08 20:19:49 UTC
[jira] [Created] (GORA-126) Improve configuration of datastore
properties
Lewis John McGibbney created GORA-126:
-----------------------------------------
Summary: Improve configuration of datastore properties
Key: GORA-126
URL: https://issues.apache.org/jira/browse/GORA-126
Project: Apache Gora
Issue Type: Improvement
Components: storage
Affects Versions: 0.2
Reporter: Lewis John McGibbney
Fix For: 0.3
As per the discussion [0] on our dev list, I thought it best to log this issue for future reference. Generally speaking this issue should move towards an adoption of Configuration (as this is the de facto implementation within the Hadoop ecosystem of products) object rather than the gora specific Properties object for defining datastore configuration specifics.
[0] http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-126) Improve configuration of datastore
properties
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417096#comment-13417096 ]
Ferdy Galema commented on GORA-126:
-----------------------------------
I now realize that this issue tries to change too much at once. I think it is best to split this one up into the several issues it addresses:
-Allow for setting preferred schema name. (Just implemented in GORA-150).
-Adding a better way to create store instances (DataStoreBuilder).
-Deprecate properties. (This is really big issue in itself, if all stores need to migrate).
I propose to close this issue and create separate jiras for the remaining issues. (When the time is right and people are really in need of them). For now I can live with GORA-150, because this is the true blocker for NUTCH-1365.
> Improve configuration of datastore properties
> ---------------------------------------------
>
> Key: GORA-126
> URL: https://issues.apache.org/jira/browse/GORA-126
> Project: Apache Gora
> Issue Type: Improvement
> Components: storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Attachments: GORA-126.patch
>
>
> As per the discussion [0] on our dev list, I thought it best to log this issue for future reference. Generally speaking this issue should move towards an adoption of Configuration (as this is the de facto implementation within the Hadoop ecosystem of products) object rather than the gora specific Properties object for defining datastore configuration specifics.
> [0] http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-126) Improve configuration of datastore
properties
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276654#comment-13276654 ]
Lewis John McGibbney commented on GORA-126:
-------------------------------------------
My intention to look into this in detail towards the end of this week Ferdy.
> Improve configuration of datastore properties
> ---------------------------------------------
>
> Key: GORA-126
> URL: https://issues.apache.org/jira/browse/GORA-126
> Project: Apache Gora
> Issue Type: Improvement
> Components: storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Fix For: 0.3
>
> Attachments: GORA-126.patch
>
>
> As per the discussion [0] on our dev list, I thought it best to log this issue for future reference. Generally speaking this issue should move towards an adoption of Configuration (as this is the de facto implementation within the Hadoop ecosystem of products) object rather than the gora specific Properties object for defining datastore configuration specifics.
> [0] http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-126) Improve configuration of datastore
properties
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271155#comment-13271155 ]
Ferdy Galema commented on GORA-126:
-----------------------------------
FYI I am already working on a solution that deprecates the Properties object. I'll submit the patch over here when it's done.
> Improve configuration of datastore properties
> ---------------------------------------------
>
> Key: GORA-126
> URL: https://issues.apache.org/jira/browse/GORA-126
> Project: Apache Gora
> Issue Type: Improvement
> Components: storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Fix For: 0.3
>
>
> As per the discussion [0] on our dev list, I thought it best to log this issue for future reference. Generally speaking this issue should move towards an adoption of Configuration (as this is the de facto implementation within the Hadoop ecosystem of products) object rather than the gora specific Properties object for defining datastore configuration specifics.
> [0] http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (GORA-126) Improve configuration of datastore
properties
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy Galema closed GORA-126.
-----------------------------
Resolution: Later
Fix Version/s: (was: 0.3)
> Improve configuration of datastore properties
> ---------------------------------------------
>
> Key: GORA-126
> URL: https://issues.apache.org/jira/browse/GORA-126
> Project: Apache Gora
> Issue Type: Improvement
> Components: storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Attachments: GORA-126.patch
>
>
> As per the discussion [0] on our dev list, I thought it best to log this issue for future reference. Generally speaking this issue should move towards an adoption of Configuration (as this is the de facto implementation within the Hadoop ecosystem of products) object rather than the gora specific Properties object for defining datastore configuration specifics.
> [0] http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-126) Improve configuration of datastore
properties
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274229#comment-13274229 ]
Henry Saputra commented on GORA-126:
------------------------------------
How do I test this patch?
> Improve configuration of datastore properties
> ---------------------------------------------
>
> Key: GORA-126
> URL: https://issues.apache.org/jira/browse/GORA-126
> Project: Apache Gora
> Issue Type: Improvement
> Components: storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Fix For: 0.3
>
> Attachments: GORA-126.patch
>
>
> As per the discussion [0] on our dev list, I thought it best to log this issue for future reference. Generally speaking this issue should move towards an adoption of Configuration (as this is the de facto implementation within the Hadoop ecosystem of products) object rather than the gora specific Properties object for defining datastore configuration specifics.
> [0] http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-126) Improve configuration of datastore
properties
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274289#comment-13274289 ]
Ferdy Galema commented on GORA-126:
-----------------------------------
I have not yet added tests for the new functionality. Tests I have done include an integrated test with Nutch, specifically NUTCH-1365 and with the HBaseStore. (But I tried to make it work with the other store implementation in mind too: The patch does not change HBaseStore specifics). Existing functionality should not be affected. Note that some aspects did not work anyway such as changing Properties in runtime.
I like to hear if this is the right direction to go. Maybe you think deprecating the entire DataStoreFactory is unnecessary, or perhaps you do not want to deprecate Properties at all? Do we need preferredSchemaName? Stuff like this would be useful feedback.
When there is some consensus on this I will add tests later on.
> Improve configuration of datastore properties
> ---------------------------------------------
>
> Key: GORA-126
> URL: https://issues.apache.org/jira/browse/GORA-126
> Project: Apache Gora
> Issue Type: Improvement
> Components: storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Fix For: 0.3
>
> Attachments: GORA-126.patch
>
>
> As per the discussion [0] on our dev list, I thought it best to log this issue for future reference. Generally speaking this issue should move towards an adoption of Configuration (as this is the de facto implementation within the Hadoop ecosystem of products) object rather than the gora specific Properties object for defining datastore configuration specifics.
> [0] http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GORA-126) Improve configuration of datastore
properties
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy Galema updated GORA-126:
------------------------------
Attachment: GORA-126.patch
Patch done. In summary it:
-Deprecates Properties (but does not remove it so backwards compatibility is kept for now).
-Introduces DataStoreBuilder to simplify datastore creation.
-Adds to concept of "preferredSchemaName" that is a replacement for the malfunctioning "default schema name" on the Properties object.
Please let me know if you have comments/suggestions.
> Improve configuration of datastore properties
> ---------------------------------------------
>
> Key: GORA-126
> URL: https://issues.apache.org/jira/browse/GORA-126
> Project: Apache Gora
> Issue Type: Improvement
> Components: storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Fix For: 0.3
>
> Attachments: GORA-126.patch
>
>
> As per the discussion [0] on our dev list, I thought it best to log this issue for future reference. Generally speaking this issue should move towards an adoption of Configuration (as this is the de facto implementation within the Hadoop ecosystem of products) object rather than the gora specific Properties object for defining datastore configuration specifics.
> [0] http://mail-archives.apache.org/mod_mbox/gora-dev/201205.mbox/%3CCALnqbSx8JLVYNQZ6gKRM%3DAb3CB-MQSjt96G%3D8YGkSXWeJJV2bA%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira