You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2009/07/17 21:00:15 UTC
[jira] Created: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
---------------------------------------------------------------------------------------------------------------------------------------------------
Key: HDFS-493
URL: https://issues.apache.org/jira/browse/HDFS-493
Project: Hadoop HDFS
Issue Type: Improvement
Components: build, test
Reporter: Konstantin Boudnik
Assignee: Konstantin Boudnik
New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733294#action_12733294 ]
Hadoop QA commented on HDFS-493:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12414019/HDFS-493.patch
against trunk revision 794953.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/26/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/26/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/26/console
This message is automatically generated.
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-493:
----------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Cos!
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-493.patch, HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-493:
----------------------------------------
Affects Version/s: 0.21.0
Fix Version/s: 0.21.0
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Affects Versions: 0.21.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0
>
> Attachments: HDFS-493.patch, HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734833#action_12734833 ]
Tsz Wo (Nicholas), SZE commented on HDFS-493:
---------------------------------------------
Tried "ant run-test-hdfs" and "ant run-test-hdfs-fault-inject" with the codes posted in HDFS-483. Both worked fine.
Since only build.xml is changed by the patch, test-patch and unit tests are not related. I will commit it soon.
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-493.patch, HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-493:
------------------------------------
Attachment: HDFS-493.patch
A proposed fix for the issue
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-493:
------------------------------------
Status: Patch Available (was: Open)
This patch creates a number of conditions for tests execution. This is needed to distinguish between FI-related and non-FI tests, because their sources are taken from different places and shouldn't interleave with each other.
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-493:
----------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-493.patch, HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733271#action_12733271 ]
Konstantin Boudnik commented on HDFS-493:
-----------------------------------------
Also, patch introduces the notion that FI related tests have a lightly different naming convention. E.g.
{noformat}
<property name="test.include" value="TestFi*"/>
{noformat}
this should be considered when new tests are developed
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-493) Only fault-injected tests have to be
executed by run-test-*-faul-inject targets; none of fault-injected tests
need to be ran normal testing process
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-493:
------------------------------------
Attachment: HDFS-493.patch
Resolving the conflicts caused by the fix of HDFS-458
> Only fault-injected tests have to be executed by run-test-*-faul-inject targets; none of fault-injected tests need to be ran normal testing process
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-493
> URL: https://issues.apache.org/jira/browse/HDFS-493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HDFS-493.patch, HDFS-493.patch
>
>
> New fault injection related tests will be executed by non fault-injected targets (e.g. run-test-hdfs, run-test-hdfs-with-mr) over un-instrumented classes. Such behavior will be potentially misleading because fault-injected tests are likely to expect a different system's behavior when faults are injected into the classes.
>
> Similarly, new targets introduced by HDFS-475 - run-test-hdfs-fault-inject and run-test-hdfs-with-mr-fault-inject will run normal (non-FI) tests with faults turned on which is likely to fall because of aforementioned reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.