You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Karishma Gulati <gu...@yahoo.com> on 2014/09/15 13:38:40 UTC
Review Request 25639: add test to falcon regression for change made in
default behaviour of instance request
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25639/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
Changes have been made to the behaviour of instance request. All instance tests will need to be modified to accommodate the same.
Details of changes made can be found in
https://issues.apache.org/jira/browse/FALCON-166
-Deleted some redundant tests. For eg: deleted testProcessInstanceResumeWithinRange, as it's the same as testProcessInsatnceResumeMany.
-Instead of generating a large amount of test data between a start and end date for every test, made use of "createMissingDependencies" which just creates the directories that the process instances are waiting on.
-Instead of putting the thread to sleep after certain requests, made use of functions like "waitTillInstancesAreCreated" and "waitTillInstanceReachState"
-Modified tests based on the following changes:
-end date defaults to end date of entity if specified as beyond entity end date
-Similarly start date defaults to start of entity
-Both start and end are optional now. However, a couple of tests where both
start and end are not mentioned for APIs like kill/suspend are allowed
to fail. Refer to Jira : https://issues.apache.org/jira/browse/FALCON-710 for
details.
-When specifying a range (start/end) for instance requests, the range is end date exclusive. Has been brought up in jira: https://issues.apache.org/jira/browse/FALCON-715
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 9b8eb30
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 4ae6d72
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java a4c9619
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java 7a7e735
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java ad731bf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 9497a49
Diff: https://reviews.apache.org/r/25639/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25639: [Falcon-645] Add test in falcon regression
for change made in default behaviour of instance request
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25639/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 11:12 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
Changes have been made to the behaviour of instance request. All instance tests will need to be modified to accommodate the same.
Details of changes made can be found in
https://issues.apache.org/jira/browse/FALCON-166
-Deleted some redundant tests. For eg: deleted testProcessInstanceResumeWithinRange, as it's the same as testProcessInsatnceResumeMany.
-Instead of generating a large amount of test data between a start and end date for every test, made use of "createMissingDependencies" which just creates the directories that the process instances are waiting on.
-Instead of putting the thread to sleep after certain requests, made use of functions like "waitTillInstancesAreCreated" and "waitTillInstanceReachState"
-Modified tests based on the following changes:
-end date defaults to end date of entity if specified as beyond entity end date
-Similarly start date defaults to start of entity
-Both start and end are optional now. However, a couple of tests where both
start and end are not mentioned for APIs like kill/suspend are allowed
to fail. Refer to Jira : https://issues.apache.org/jira/browse/FALCON-710 for
details.
-When specifying a range (start/end) for instance requests, the range is end date exclusive. Has been brought up in jira: https://issues.apache.org/jira/browse/FALCON-715
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 9b8eb30
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 4ae6d72
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java a4c9619
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java 7a7e735
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java ad731bf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 9497a49
Diff: https://reviews.apache.org/r/25639/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25639: [Falcon-645] Add test in falcon regression
for change made in default behaviour of instance request
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25639/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 12:28 p.m.)
Review request for Falcon.
Summary (updated)
-----------------
[Falcon-645] Add test in falcon regression for change made in default behaviour of instance request
Repository: falcon-git
Description
-------
Changes have been made to the behaviour of instance request. All instance tests will need to be modified to accommodate the same.
Details of changes made can be found in
https://issues.apache.org/jira/browse/FALCON-166
-Deleted some redundant tests. For eg: deleted testProcessInstanceResumeWithinRange, as it's the same as testProcessInsatnceResumeMany.
-Instead of generating a large amount of test data between a start and end date for every test, made use of "createMissingDependencies" which just creates the directories that the process instances are waiting on.
-Instead of putting the thread to sleep after certain requests, made use of functions like "waitTillInstancesAreCreated" and "waitTillInstanceReachState"
-Modified tests based on the following changes:
-end date defaults to end date of entity if specified as beyond entity end date
-Similarly start date defaults to start of entity
-Both start and end are optional now. However, a couple of tests where both
start and end are not mentioned for APIs like kill/suspend are allowed
to fail. Refer to Jira : https://issues.apache.org/jira/browse/FALCON-710 for
details.
-When specifying a range (start/end) for instance requests, the range is end date exclusive. Has been brought up in jira: https://issues.apache.org/jira/browse/FALCON-715
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 9b8eb30
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 4ae6d72
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java a4c9619
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java 7a7e735
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java ad731bf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 9497a49
Diff: https://reviews.apache.org/r/25639/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25639: add test to falcon regression for change
made in default behaviour of instance request
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25639/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 11:39 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
Changes have been made to the behaviour of instance request. All instance tests will need to be modified to accommodate the same.
Details of changes made can be found in
https://issues.apache.org/jira/browse/FALCON-166
-Deleted some redundant tests. For eg: deleted testProcessInstanceResumeWithinRange, as it's the same as testProcessInsatnceResumeMany.
-Instead of generating a large amount of test data between a start and end date for every test, made use of "createMissingDependencies" which just creates the directories that the process instances are waiting on.
-Instead of putting the thread to sleep after certain requests, made use of functions like "waitTillInstancesAreCreated" and "waitTillInstanceReachState"
-Modified tests based on the following changes:
-end date defaults to end date of entity if specified as beyond entity end date
-Similarly start date defaults to start of entity
-Both start and end are optional now. However, a couple of tests where both
start and end are not mentioned for APIs like kill/suspend are allowed
to fail. Refer to Jira : https://issues.apache.org/jira/browse/FALCON-710 for
details.
-When specifying a range (start/end) for instance requests, the range is end date exclusive. Has been brought up in jira: https://issues.apache.org/jira/browse/FALCON-715
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 9b8eb30
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 4ae6d72
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java a4c9619
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java 7a7e735
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java ad731bf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 9497a49
Diff: https://reviews.apache.org/r/25639/diff/
Testing
-------
Thanks,
Karishma Gulati