[GitHub] [geode] upthewaterspout opened pull request #2682: GEODE-5863: Rewrite CQ test that wasn't testing anything

["upthewaterspout (GitHub)" <gi...@apache.org>]

testMultipleExecuteWithInitialResults was not actually testing anything
because it fired off asynchronous tasks, but failed to see if those
tasks threw an exception.

Before this fix, the test always got an exception.  It installed a
test hook to prevent the CQ from starting. That prevented any events
from being queued up. The test then waited for all events to be received
on the client, which timed out.

Reimplemented the test to test the condition described in the comments,
making sure that calling executeWithInitialResults twice does not lose
events that are queued up already.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2682 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #2682: GEODE-5863: Rewrite CQ test that wasn't testing anything

["agingade (GitHub)" <gi...@apache.org>]

Test changes doesn't seem to be doing what its was originally intend to do. Previously with the test-hook; its making one of the thread to be waiting for "queuedEventsSynchObject" while other thread is doing Cq query execution.

[ Full content available at: https://github.com/apache/geode/pull/2682 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout closed pull request #2682: GEODE-5863: Rewrite CQ test that wasn't testing anything

["upthewaterspout (GitHub)" <gi...@apache.org>]

[ pull request closed by upthewaterspout ]

[ Full content available at: https://github.com/apache/geode/pull/2682 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout commented on issue #2682: GEODE-5863: Rewrite CQ test that wasn't testing anything

["upthewaterspout (GitHub)" <gi...@apache.org>]

Based on the comment @agingade, I will close this PR and see if I can fix this code a different way to either make sure we can get both threads stuck in exactly the spot where the test hook is called *or* change the code so that the whole executeWithInitialResults is synchronized and this race is impossible.

[ Full content available at: https://github.com/apache/geode/pull/2682 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org