[GitHub] [spark] edwinalu commented on a change in pull request #23767: [SPARK-26329][CORE][WIP] Faster polling of executor memory metrics.

[GitBox <gi...@apache.org>]

edwinalu commented on a change in pull request #23767: [SPARK-26329][CORE][WIP] Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r262195822
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala
 ##########
 @@ -218,9 +218,7 @@ class ReplayListenerSuite extends SparkFunSuite with BeforeAndAfter with LocalSp
 
     // Verify the same events are replayed in the same order
     assert(sc.eventLogger.isDefined)
-    val originalEvents = sc.eventLogger.get.loggedEvents.filter { e =>
-      !JsonProtocol.sparkEventFromJson(e).isInstanceOf[SparkListenerStageExecutorMetrics]
-    }
+    val originalEvents = sc.eventLogger.get.loggedEvents
 
 Review comment:
   Sorry for the delay. I also don't remember the details. It is aggregating the metrics, and logging only at stage end, but this should be true for both, and removing the filter seems right, looking at the code now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org