You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2026/09/24 13:57:15 UTC
[PR] refactor(common): drop stale HoodieTableConfigUtils copies [hudi]
voonhous opened a new pull request, #20051:
URL: https://github.com/apache/hudi/pull/20051
### Describe the issue this Pull Request addresses
`HoodieTableConfigUtils` holds five partition-field statics (`getPartitionFieldPropForKeyGenerator`, `getPartitionFieldProp`, `getPartitionFields`, `getPartitionFieldWithoutKeyGenPartitionType`, `getTableVersion`) that also exist on `HoodieTableConfig` under the same names. Nothing in the repo calls the util copies. Every caller uses the `HoodieTableConfig` versions.
#11601 moved these methods into `HoodieTableConfig` and deleted `HoodieTableConfigUtils`. #11866 then brought the file back with the old bodies, most likely during a rebase. The copies have been dead since, and they have missed two later fixes to the live versions:
- #11710 removed the `tableVersion > SEVEN` guard in `getPartitionFieldProp` / `getPartitionFieldWithoutKeyGenPartitionType`. The util copy still has it.
- #18423 trims partition fields and splits on `BaseKeyGenerator.FIELD_SEPARATOR`. The util copy still splits on a hardcoded `","` with no trim.
### Summary and Changelog
- Delete the five stale methods and their now-unused imports from `HoodieTableConfigUtils`.
- Keep `inferPartitionValueExtractorClass` (added in #17850), which `HoodieTableConfig`, `HoodieSyncConfig`, `HoodieCatalogTable` and `ProvidesHoodieConfig` use.
### Impact
None at runtime. The removed methods are public but have no in-repo caller. Any outside caller can switch to the method of the same name on `HoodieTableConfig`.
### Risk Level
none
### Documentation Update
none
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(common): drop stale HoodieTableConfigUtils copies [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #20051:
URL: https://github.com/apache/hudi/pull/20051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(common): drop stale HoodieTableConfigUtils copies [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20051:
URL: https://github.com/apache/hudi/pull/20051#issuecomment-5816196169
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/20051?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 80.38%. Comparing base ([`513edcf`](https://app.codecov.io/gh/apache/hudi/commit/513edcf8c5e0a811699d2d9db2645252cd158199?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7e86de5`](https://app.codecov.io/gh/apache/hudi/commit/7e86de52ff05c58697bc8e6f777a14cfd0a27695?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #20051 +/- ##
=========================================
Coverage 80.37% 80.38%
Complexity 34794 34794
=========================================
Files 2545 2545
Lines 142722 142706 -16
Branches 17336 17336
=========================================
Hits 114708 114708
+ Misses 20104 20088 -16
Partials 7910 7910
```
| [Components](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hudi-common](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.94% <ø> (+0.03%)` | :arrow_up: |
| [hudi-client](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.43% <ø> (ø)` | |
| [hudi-flink](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.68% <ø> (ø)` | |
| [hudi-spark-datasource](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.78% <ø> (ø)` | |
| [hudi-utilities](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.15% <ø> (ø)` | |
| [hudi-cli](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.99% <ø> (ø)` | |
| [hudi-hadoop](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.98% <ø> (ø)` | |
| [hudi-sync](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.02% <ø> (ø)` | |
| [hudi-io](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.57% <ø> (ø)` | |
| [hudi-timeline-service](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.34% <ø> (ø)` | |
| [hudi-cloud](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | |
| [hudi-kafka-connect](https://app.codecov.io/gh/apache/hudi/pull/20051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.96% <ø> (ø)` | |
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/20051/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/20051/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.87% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/20051?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/common/util/HoodieTableConfigUtils.java](https://app.codecov.io/gh/apache/hudi/pull/20051?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Futil%2FHoodieTableConfigUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvSG9vZGllVGFibGVDb25maWdVdGlscy5qYXZh) | `94.44% <ø> (+44.44%)` | :arrow_up: |
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(common): drop stale HoodieTableConfigUtils copies [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #20051:
URL: https://github.com/apache/hudi/pull/20051#issuecomment-5815835002
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e86de52ff05c58697bc8e6f777a14cfd0a27695",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e86de52ff05c58697bc8e6f777a14cfd0a27695",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e86de52ff05c58697bc8e6f777a14cfd0a27695 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org