You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/08/01 04:18:40 UTC

[GitHub] [iceberg-rust] Xuanwo opened a new pull request, #15: chore: Change iceberg into workspace

Xuanwo opened a new pull request, #15:
URL: https://github.com/apache/iceberg-rust/pull/15

   This PR will change iceberg into workspace. I feel like it's better to split iceberg features into different crates so that we can work concurrently inside of waiting for the release of a whole iceberg.
   
   For example, we can add iceberg rest api client first (which could be generated from OpenDAL Specs).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] Xuanwo commented on pull request #15: chore: Change iceberg into workspace

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659540849

   cc @Fokko, @JanKaul, @liurenjie1024 & @ZENOTME to take a look. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] liurenjie1024 commented on pull request #15: chore: Change iceberg into workspace

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659553845

   >  it's better to release iceberg as a whole instead of bunch of crates?
   
   I prefer small crates have several advantages:
   
   1. Putting things in different crates helps to clarify dependencies relationships.
   2. Faster compilation speed.
   
   For example I want to put datafusion integration in another crate.
   
   > Can we release iceberg-rest-catalog-client seperately?
   
   I think it's better to make it part of core crate?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] Fokko commented on pull request #15: chore: Change iceberg into workspace

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659644909

   Releasing takes some effort, but if everything is well automated, and there are folks around to test and validate the release, then it is a quick process. Even if it is not a lot of effort, it takes 3 days because everyone needs to be able to chime in and test the release. It would be great to set up a how-to-release guide, examples for [Java](https://iceberg.apache.org/how-to-release/) and [Python](https://py.iceberg.apache.org/how-to-release/) can be used for inspiration :)
   
   What I think would be easiest, but correct me if I'm wrong here. Just release all the crates every time with the same version, so the versions of the crates don't diverge. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] liurenjie1024 commented on pull request #15: chore: Change iceberg into workspace

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659659729

   > What I think would be easiest, but correct me if I'm wrong here. Just release all the crates every time with the same version, so the versions of the crates don't diverge. WDYT?
   Agree.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] Fokko merged pull request #15: chore: Change iceberg into workspace

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] Xuanwo commented on pull request #15: chore: Change iceberg into workspace

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659557504

   > I think it's better to make it part of core crate?
   
   Both LGTM. My motivation is to release it sooner, allowing us to involve more users and developers in our project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] liurenjie1024 commented on pull request #15: chore: Change iceberg into workspace

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659699424

   > If we are going to release everything in the same version, it's better to put them in the same crate with different feature flag instead.
   
   There is a discussion about feature vs crates here: https://users.rust-lang.org/t/guidance-on-optional-functionality-crates-vs-features/85694
   
   Personally, I prefer to put standalone things in crates for better structure and maintainability, also better documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] Xuanwo commented on pull request #15: chore: Change iceberg into workspace

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659683691

   > Just release all the crates every time with the same version, so the versions of the crates don't diverge. WDYT?
   
   I'm not sure about that. Maybe we can release `iceberg-rest-catalog-client` with `0.0.1` and `iceberg` with `0.2.0`?
   
   If we are going to release everything in the same version, it's better to put them in the same crate with diffent feature flag instead.
   
   > NOTE: feature flag in rust is similiar to `pip install package[addon]`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] JanKaul commented on pull request #15: chore: Change iceberg into workspace

Posted by "JanKaul (via GitHub)" <gi...@apache.org>.
JanKaul commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659724057

   I'm definitely in favor of small crates compared to using features. From my perspective features can get really messy when there is a hierarchy of crates depending on each other (Crate A uses feature 1 of `iceberg` and crate B wants to use crate A without feature 1 and so on). Plus compile times should be much better.
   
   There is one downside. You cannot implement traits for structs defined outside of your crate. So if you want to implement Datafusions `TableProvider` for example, you have to create a wrapper struct like so:
   
   ```
   struct DatafusionTable(IcebergTable);
   ```
   
   Reagrding the release cadence, I have no preference. We could release the small crates all with the same version number or release them separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-rust] Xuanwo commented on pull request #15: chore: Change iceberg into workspace

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #15:
URL: https://github.com/apache/iceberg-rust/pull/15#issuecomment-1659546978

   The problem is the release process.
   
   - Can we release `iceberg-rest-catalog-client` seperately?
   - Is it a heavy work?
   
   Need more input from @Fokko.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org