You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by Danny Robinson <da...@gmail.com> on 2007/08/28 17:49:22 UTC

[TRINIDAD] Proposal - Private Settings made Public

Just wanted your comments/votes on the following web.xml settings that we've
previously agreed should be made public for 1.0.3:

org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
becomes
org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS

AND

org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
becomes
org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION

Thanks,

Danny
-- 
Chordiant Software Inc.
www.chordiant.com

Re: [TRINIDAD] Proposal - Private Settings made Public

Posted by Simon Lessard <si...@gmail.com>.

eh, true. I focused mainly on the name and trinidadinternal --> trinidad
changes, renderkit should indeed disappear.

On 8/28/07, Adam Winer <aw...@gmail.com> wrote:
>
> On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> > I agree on removing 'renderkit', I'd left it in there as you'd
> originally
> > defined the private version and I thought 'renderkit' was there for a
> > reason. ;-)
>
> For private variables, because they proliferate so and aren't
> centrally documented, I like to keep them disambiguated
> by package.  For public variables, the package-with-which-the-
> functionality-is-associated is an implementation detail that
> most shouldn't remember.  (Trinidad isn't consistent on this
> front though)
>
> -- Adam
>
>
> >
> > I'll make the change to make things simpler.
> >
> > D.
> >
> > On 8/28/07, Adam Winer <aw...@gmail.com> wrote:
> > > On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> > > > Just wanted your comments/votes on the following web.xml settings
> that
> > we've
> > > > previously agreed should be made public for 1.0.3:
> > > >
> > > >
> > org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
> > > > becomes
> > > >
> > org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS
> > >
> > > Don't think we need "renderkit" in there, but I like the name change:
> > >
> > > org.apache.myfaces.trinidad.ENABLE_LIGHTWEIGHT_DIALOGS
> > >
> > >
> > > > AND
> > > >
> > > >
> > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > > > becomes
> > > > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> > >
> > > Maybe we should rename this?
> > >
> > > org.apache.myfaces.trinidad.DISABLE_STYLE_COMPRESSION
> > >
> > > -- Adam
> > >
> > > >
> > > > Thanks,
> > > >
> > > > Danny
> > > > --
> > > > Chordiant Software Inc.
> > > > www.chordiant.com
> > >
> >
> >
> >
> > --
> >
> > Chordiant Software Inc.
> > www.chordiant.com
>

Re: [TRINIDAD] Proposal - Private Settings made Public

Posted by Adam Winer <aw...@gmail.com>.

On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> I agree on removing 'renderkit', I'd left it in there as you'd originally
> defined the private version and I thought 'renderkit' was there for a
> reason. ;-)

For private variables, because they proliferate so and aren't
centrally documented, I like to keep them disambiguated
by package.  For public variables, the package-with-which-the-
functionality-is-associated is an implementation detail that
most shouldn't remember.  (Trinidad isn't consistent on this
front though)

-- Adam


>
> I'll make the change to make things simpler.
>
> D.
>
> On 8/28/07, Adam Winer <aw...@gmail.com> wrote:
> > On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> > > Just wanted your comments/votes on the following web.xml settings that
> we've
> > > previously agreed should be made public for 1.0.3:
> > >
> > >
> org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
> > > becomes
> > >
> org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS
> >
> > Don't think we need "renderkit" in there, but I like the name change:
> >
> > org.apache.myfaces.trinidad.ENABLE_LIGHTWEIGHT_DIALOGS
> >
> >
> > > AND
> > >
> > >
> org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > > becomes
> > > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> >
> > Maybe we should rename this?
> >
> > org.apache.myfaces.trinidad.DISABLE_STYLE_COMPRESSION
> >
> > -- Adam
> >
> > >
> > > Thanks,
> > >
> > > Danny
> > > --
> > > Chordiant Software Inc.
> > > www.chordiant.com
> >
>
>
>
> --
>
> Chordiant Software Inc.
> www.chordiant.com

Re: [TRINIDAD] Proposal - Private Settings made Public

Posted by Danny Robinson <da...@gmail.com>.

I agree on removing 'renderkit', I'd left it in there as you'd originally
defined the private version and I thought 'renderkit' was there for a
reason. ;-)

I'll make the change to make things simpler.

D.
On 8/28/07, Adam Winer <aw...@gmail.com> wrote:
>
> On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> > Just wanted your comments/votes on the following web.xml settings that
> we've
> > previously agreed should be made public for 1.0.3:
> >
> > org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
> > becomes
> > org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS
>
> Don't think we need "renderkit" in there, but I like the name change:
>
> org.apache.myfaces.trinidad.ENABLE_LIGHTWEIGHT_DIALOGS
>
>
> > AND
> >
> > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > becomes
> > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
>
> Maybe we should rename this?
>
> org.apache.myfaces.trinidad.DISABLE_STYLE_COMPRESSION
>
> -- Adam
>
> >
> > Thanks,
> >
> > Danny
> > --
> > Chordiant Software Inc.
> > www.chordiant.com
>



-- 
Chordiant Software Inc.
www.chordiant.com

Re: [TRINIDAD] Proposal - Private Settings made Public

Posted by Adam Winer <aw...@gmail.com>.

On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> Just wanted your comments/votes on the following web.xml settings that we've
> previously agreed should be made public for 1.0.3:
>
> org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
> becomes
> org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS

Don't think we need "renderkit" in there, but I like the name change:

org.apache.myfaces.trinidad.ENABLE_LIGHTWEIGHT_DIALOGS


> AND
>
> org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> becomes
> org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION

Maybe we should rename this?

org.apache.myfaces.trinidad.DISABLE_STYLE_COMPRESSION

-- Adam

>
> Thanks,
>
> Danny
> --
> Chordiant Software Inc.
> www.chordiant.com

Re: [TRINIDAD] Proposal - Private Settings made Public

Posted by Danny Robinson <da...@gmail.com>.

Thanks guys, I'll make these changes.

On 8/28/07, Jeanne Waldman <je...@oracle.com> wrote:
>
>  +1
>
> Simon Lessard wrote:
>
> I like both, so
>
> org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
> becomes
> org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT _DIALOGS
> +1
>
> org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> becomes
> org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> +1
>
> ~ Simon
>
> On 8/28/07, Matthias Wessendorf <ma...@apache.org> wrote:
> >
> > with documentation on them, sure +1
> > (at least on the very handy DISABLE_CONTENT_COMPRESSION param)
> >
> > -M
> >
> > On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> > > Just wanted your comments/votes on the following web.xml settings that
> > we've
> > > previously agreed should be made public for 1.0.3:
> > >
> > > org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
> > > becomes
> > > org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS
> > >
> > > AND
> > >
> > > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > > becomes
> > > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> > >
> > > Thanks,
> > >
> > > Danny
> > > --
> > > Chordiant Software Inc.
> > > www.chordiant.com
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > mail: matzew-at-apache-dot-org
> >
>
>


-- 
Chordiant Software Inc.
www.chordiant.com

Re: [TRINIDAD] Proposal - Private Settings made Public

Posted by Simon Lessard <si...@gmail.com>.

I like both, so

org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
becomes
org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS
+1

org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
becomes
org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
+1

~ Simon

On 8/28/07, Matthias Wessendorf <ma...@apache.org> wrote:
>
> with documentation on them, sure +1
> (at least on the very handy DISABLE_CONTENT_COMPRESSION param)
>
> -M
>
> On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> > Just wanted your comments/votes on the following web.xml settings that
> we've
> > previously agreed should be made public for 1.0.3:
> >
> > org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
> > becomes
> > org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS
> >
> > AND
> >
> > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > becomes
> > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> >
> > Thanks,
> >
> > Danny
> > --
> > Chordiant Software Inc.
> > www.chordiant.com
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> mail: matzew-at-apache-dot-org
>

Re: [TRINIDAD] Proposal - Private Settings made Public

Posted by Matthias Wessendorf <ma...@apache.org>.

with documentation on them, sure +1
(at least on the very handy DISABLE_CONTENT_COMPRESSION param)

-M

On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> Just wanted your comments/votes on the following web.xml settings that we've
> previously agreed should be made public for 1.0.3:
>
> org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP
> becomes
> org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS
>
> AND
>
> org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> becomes
> org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
>
> Thanks,
>
> Danny
> --
> Chordiant Software Inc.
> www.chordiant.com


-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org