You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Lars Bruun-Hansen <lb...@gmail.com> on 2017/10/30 15:15:03 UTC
No more modules to review?
I've done 5-6 modules.
Now - for the first time - all modules have a name next to them. (except a
few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
I'll be happy to do more if someone has signed up for more than they can
chew. :-)
Let me know.
RE: No more modules to review?
Posted by Eric Barboni <sk...@apache.org>.
Hi,
A quick maven plugin to generate two web page ( à la maven) to get the short list of stuff maybe not done yep splited by external and licence
https://github.com/apache/incubator-netbeans-tools/pull/2
mvn clean install site
Regards
Eric
-----Message d'origine-----
De : Geertjan Wielenga [mailto:geertjan.wielenga@googlemail.com]
Envoyé : lundi 30 octobre 2017 18:36
À : dev@netbeans.incubator.apache.org
Objet : Re: No more modules to review?
In principle, yes. But in some cases there may be items that should be solved centrally.
There could also be mistakes, of course.
Gj
On Mon, Oct 30, 2017 at 6:34 PM, Eric Barboni <sk...@apache.org> wrote:
> Hi,
> Does "Done" status means Rat report is ok ?
> Checking platform cluster [1] give the following list of module with
> "done" status:
>
> module autoupdate.services has 1 unapproved license(s) module
> openide.nodes has 12 unapproved license(s) module openide.options has
> 6 unapproved license(s) module openide.windows has 6 unapproved
> license(s)
>
> Others are under review.
>
> I can edit CWIKI and put a link to precise testReport in each cell
> that are not ok yet so reviewer can remove it when it is ok (deadlink).
>
> Regards
> Eric
>
> [1] https://builds.apache.org/job/incubator-netbeans-linux/
> lastCompletedBuild/testReport/(root)/Cluster_%20platform/
> -----Message d'origine-----
> De : Lars Bruun-Hansen [mailto:lbruunhansen@gmail.com] Envoyé : lundi
> 30 octobre 2017 17:32 À : dev@netbeans.incubator.apache.org; Emilian
> Bold < emilian.bold@protonmail.ch> Objet : Re: No more modules to
> review?
>
> Thx. I'll look at Emilian's suggestion tonight.
>
> On 30 Oct 2017 17:12, "Emilian Bold" <em...@protonmail.ch> wrote:
>
> > There are some here https://github.com/emilianbold/incubator-
> > netbeans/issues with no progress for days. You could pick one (and
> > announce on the issue).
> >
> > --emi
> >
> > >-------- Original Message --------
> > >Subject: No more modules to review?
> > >Local Time: October 30, 2017 5:15 PM UTC Time: October 30, 2017
> > >3:15 PM
> > >From: lbruunhansen@gmail.com
> > >To: dev@netbeans.incubator.apache.org
> > >
> > >I've done 5-6 modules.
> > > Now - for the first time - all modules have a name next to them.
> > >(except
> > a
> > > few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
> > >
> > > I'll be happy to do more if someone has signed up for more than
> > > they can chew. :-) Let me know.
> > >
>
>
Re: No more modules to review?
Posted by Geertjan Wielenga <ge...@googlemail.com>.
In principle, yes. But in some cases there may be items that should be
solved centrally.
There could also be mistakes, of course.
Gj
On Mon, Oct 30, 2017 at 6:34 PM, Eric Barboni <sk...@apache.org> wrote:
> Hi,
> Does "Done" status means Rat report is ok ?
> Checking platform cluster [1] give the following list of module with
> "done" status:
>
> module autoupdate.services has 1 unapproved license(s)
> module openide.nodes has 12 unapproved license(s)
> module openide.options has 6 unapproved license(s)
> module openide.windows has 6 unapproved license(s)
>
> Others are under review.
>
> I can edit CWIKI and put a link to precise testReport in each cell that
> are not ok yet so reviewer can remove it when it is ok (deadlink).
>
> Regards
> Eric
>
> [1] https://builds.apache.org/job/incubator-netbeans-linux/
> lastCompletedBuild/testReport/(root)/Cluster_%20platform/
> -----Message d'origine-----
> De : Lars Bruun-Hansen [mailto:lbruunhansen@gmail.com]
> Envoyé : lundi 30 octobre 2017 17:32
> À : dev@netbeans.incubator.apache.org; Emilian Bold <
> emilian.bold@protonmail.ch>
> Objet : Re: No more modules to review?
>
> Thx. I'll look at Emilian's suggestion tonight.
>
> On 30 Oct 2017 17:12, "Emilian Bold" <em...@protonmail.ch> wrote:
>
> > There are some here https://github.com/emilianbold/incubator-
> > netbeans/issues with no progress for days. You could pick one (and
> > announce on the issue).
> >
> > --emi
> >
> > >-------- Original Message --------
> > >Subject: No more modules to review?
> > >Local Time: October 30, 2017 5:15 PM
> > >UTC Time: October 30, 2017 3:15 PM
> > >From: lbruunhansen@gmail.com
> > >To: dev@netbeans.incubator.apache.org
> > >
> > >I've done 5-6 modules.
> > > Now - for the first time - all modules have a name next to them.
> > >(except
> > a
> > > few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
> > >
> > > I'll be happy to do more if someone has signed up for more than they
> > > can chew. :-) Let me know.
> > >
>
>
RE: No more modules to review?
Posted by Eric Barboni <sk...@apache.org>.
Hi,
Does "Done" status means Rat report is ok ?
Checking platform cluster [1] give the following list of module with "done" status:
module autoupdate.services has 1 unapproved license(s)
module openide.nodes has 12 unapproved license(s)
module openide.options has 6 unapproved license(s)
module openide.windows has 6 unapproved license(s)
Others are under review.
I can edit CWIKI and put a link to precise testReport in each cell that are not ok yet so reviewer can remove it when it is ok (deadlink).
Regards
Eric
[1] https://builds.apache.org/job/incubator-netbeans-linux/lastCompletedBuild/testReport/(root)/Cluster_%20platform/
-----Message d'origine-----
De : Lars Bruun-Hansen [mailto:lbruunhansen@gmail.com]
Envoyé : lundi 30 octobre 2017 17:32
À : dev@netbeans.incubator.apache.org; Emilian Bold <em...@protonmail.ch>
Objet : Re: No more modules to review?
Thx. I'll look at Emilian's suggestion tonight.
On 30 Oct 2017 17:12, "Emilian Bold" <em...@protonmail.ch> wrote:
> There are some here https://github.com/emilianbold/incubator-
> netbeans/issues with no progress for days. You could pick one (and
> announce on the issue).
>
> --emi
>
> >-------- Original Message --------
> >Subject: No more modules to review?
> >Local Time: October 30, 2017 5:15 PM
> >UTC Time: October 30, 2017 3:15 PM
> >From: lbruunhansen@gmail.com
> >To: dev@netbeans.incubator.apache.org
> >
> >I've done 5-6 modules.
> > Now - for the first time - all modules have a name next to them.
> >(except
> a
> > few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
> >
> > I'll be happy to do more if someone has signed up for more than they
> > can chew. :-) Let me know.
> >
Re: No more modules to review?
Posted by Lars Bruun-Hansen <lb...@gmail.com>.
Thx. I'll look at Emilian's suggestion tonight.
On 30 Oct 2017 17:12, "Emilian Bold" <em...@protonmail.ch> wrote:
> There are some here https://github.com/emilianbold/incubator-
> netbeans/issues with no progress for days. You could pick one (and
> announce on the issue).
>
> --emi
>
> >-------- Original Message --------
> >Subject: No more modules to review?
> >Local Time: October 30, 2017 5:15 PM
> >UTC Time: October 30, 2017 3:15 PM
> >From: lbruunhansen@gmail.com
> >To: dev@netbeans.incubator.apache.org
> >
> >I've done 5-6 modules.
> > Now - for the first time - all modules have a name next to them. (except
> a
> > few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
> >
> > I'll be happy to do more if someone has signed up for more than they can
> > chew. :-)
> > Let me know.
> >
Re: No more modules to review?
Posted by Emilian Bold <em...@protonmail.ch>.
There are some here https://github.com/emilianbold/incubator-netbeans/issues with no progress for days. You could pick one (and announce on the issue).
--emi
>-------- Original Message --------
>Subject: No more modules to review?
>Local Time: October 30, 2017 5:15 PM
>UTC Time: October 30, 2017 3:15 PM
>From: lbruunhansen@gmail.com
>To: dev@netbeans.incubator.apache.org
>
>I've done 5-6 modules.
> Now - for the first time - all modules have a name next to them. (except a
> few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
>
> I'll be happy to do more if someone has signed up for more than they can
> chew. :-)
> Let me know.
>
Re: No more modules to review?
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Another way to approach things is to take a look at the Rat report and to
see which files are left to be done and then to do those, first figuring
out who is assigned to the related module and seeing what the hold up is,
etc.
Gj
On Mon, Oct 30, 2017 at 4:18 PM, Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
> Great and congrats!
>
> I think anything not marked 'Done' should be something that could be
> looked at.
>
> Also, I think anything marked to 'jkostaras' has been looked at, but not
> fixed -- you could take over those items, for example.
>
> Also, I've assigned everything in 'apisupport' to myself, that area could
> also be something to look at and check and take over.
>
> Many thanks for your hard work.
>
> Gj
>
> On Mon, Oct 30, 2017 at 4:15 PM, Lars Bruun-Hansen <lbruunhansen@gmail.com
> > wrote:
>
>> I've done 5-6 modules.
>> Now - for the first time - all modules have a name next to them. (except a
>> few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
>>
>> I'll be happy to do more if someone has signed up for more than they can
>> chew. :-)
>> Let me know.
>>
>
>
Re: No more modules to review?
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Great and congrats!
I think anything not marked 'Done' should be something that could be looked
at.
Also, I think anything marked to 'jkostaras' has been looked at, but not
fixed -- you could take over those items, for example.
Also, I've assigned everything in 'apisupport' to myself, that area could
also be something to look at and check and take over.
Many thanks for your hard work.
Gj
On Mon, Oct 30, 2017 at 4:15 PM, Lars Bruun-Hansen <lb...@gmail.com>
wrote:
> I've done 5-6 modules.
> Now - for the first time - all modules have a name next to them. (except a
> few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
>
> I'll be happy to do more if someone has signed up for more than they can
> chew. :-)
> Let me know.
>
Re: No more modules to review?
Posted by Emilian Bold <em...@protonmail.ch>.
Yes, but note how I'm asking on the issue for progress updates and people haven't answered in days.
Just pick one and I'll switch it to you.
Actually, I think I'll just remove myself from the cwiki page and leave them available for everybody. No sense to reserve them for #hacktoberfest when there is no progress.
--emi
>-------- Original Message --------
>Subject: Re: No more modules to review?
>Local Time: October 31, 2017 12:32 PM
>UTC Time: October 31, 2017 10:32 AM
>From: lbruunhansen@gmail.com
>To: dev@netbeans.incubator.apache.org
>
>@emilian: Your list from Hacktoberfest ( https://github.com/
> emilianbold/incubator-netbeans/issues ) all have someone who says they'll
> do it.
>
>
> I'll move on with some of the o.eclipse modules for now where I don't have
> to "steal" from someone. But next step will be "stealing". :-)
>
> On Mon, Oct 30, 2017 at 8:07 PM, Antonio Vieiro antonio@vieiro.net wrote:
>>>El 30 oct 2017, a las 16:15, Lars Bruun-Hansen lbruunhansen@gmail.com
>>> escribió:
>>>I've done 5-6 modules.
>>> Now - for the first time - all modules have a name next to them. (except
>>> a
>>> few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
>>>Nope. There’s no “vieiro” mark in the list of modules to review, so I’m
>> not looking at them. Feel free to proceed.
>>I’m just trying to make it possible to download binaries from some other
>> maven repositories, if you can find a repository for the modules at
>> o.eclipse.* (or whatever) please add the repository to the list of modules
>> to review.
>>>I'll be happy to do more if someone has signed up for more than they can
>>> chew. :-)
>>> Let me know.
>>>Perfect! Thanks,
>> Antonio
>
Re: No more modules to review?
Posted by Lars Bruun-Hansen <lb...@gmail.com>.
@emilian: Your list from Hacktoberfest ( https://github.com/
emilianbold/incubator-netbeans/issues ) all have someone who says they'll
do it.
I'll move on with some of the o.eclipse modules for now where I don't have
to "steal" from someone. But next step will be "stealing". :-)
On Mon, Oct 30, 2017 at 8:07 PM, Antonio Vieiro <an...@vieiro.net> wrote:
>
> > El 30 oct 2017, a las 16:15, Lars Bruun-Hansen <lb...@gmail.com>
> escribió:
> >
> > I've done 5-6 modules.
> > Now - for the first time - all modules have a name next to them. (except
> a
> > few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
>
> Nope. There’s no “vieiro” mark in the list of modules to review, so I’m
> not looking at them. Feel free to proceed.
>
> I’m just trying to make it possible to download binaries from some other
> maven repositories, if you can find a repository for the modules at
> o.eclipse.* (or whatever) please add the repository to the list of modules
> to review.
>
> >
> > I'll be happy to do more if someone has signed up for more than they can
> > chew. :-)
> > Let me know.
>
> Perfect! Thanks,
> Antonio
Re: No more modules to review?
Posted by Antonio Vieiro <an...@vieiro.net>.
> El 30 oct 2017, a las 16:15, Lars Bruun-Hansen <lb...@gmail.com> escribió:
>
> I've done 5-6 modules.
> Now - for the first time - all modules have a name next to them. (except a
> few o.eclipse but I'm under that Antonio Vieiro is looking at those?).
Nope. There’s no “vieiro” mark in the list of modules to review, so I’m not looking at them. Feel free to proceed.
I’m just trying to make it possible to download binaries from some other maven repositories, if you can find a repository for the modules at o.eclipse.* (or whatever) please add the repository to the list of modules to review.
>
> I'll be happy to do more if someone has signed up for more than they can
> chew. :-)
> Let me know.
Perfect! Thanks,
Antonio