You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jimexist (via GitHub)" <gi...@apache.org> on 2023/04/19 23:44:46 UTC
[GitHub] [thrift] Jimexist opened a new pull request, #2789: WIP update github workflow for python
Jimexist opened a new pull request, #2789:
URL: https://github.com/apache/thrift/pull/2789
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2789: WIP update github workflow for python
Posted by "Jimexist (via GitHub)" <gi...@apache.org>.
Jimexist commented on PR #2789:
URL: https://github.com/apache/thrift/pull/2789#issuecomment-1515807916
@fishy this is the follow up of
- #2596
however i cannot seem to find the cause of it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2789: WIP update github workflow for python
Posted by "Jimexist (via GitHub)" <gi...@apache.org>.
Jimexist commented on PR #2789:
URL: https://github.com/apache/thrift/pull/2789#issuecomment-1524317695
@fishy do you think this maybe the support of uuid in python is missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on a diff in pull request #2789: WIP update github workflow for python
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on code in PR #2789:
URL: https://github.com/apache/thrift/pull/2789#discussion_r1179354636
##########
test/py/Makefile.am:
##########
@@ -71,50 +71,50 @@ TESTS= $(py_unit_tests)
gen-py/%/__init__.py: ../%.thrift $(THRIFT)
- test -f ../v0.16/$(notdir $<) \
- && $(THRIFT) --gen py ../v0.16/$(notdir $<) \
+ test -f ../$(notdir $<) \
Review Comment:
we shouldn't change this one. the ones under `v0.16` are for the languages not have uuid implemented yet (and python is one of them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org