You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2015/06/28 07:19:26 UTC
incubator-reef git commit: [REEF-418]: Fix Group Communication on
actual clusters
Repository: incubator-reef
Updated Branches:
refs/heads/master 474760f78 -> 9c8fee2a1
[REEF-418]: Fix Group Communication on actual clusters
This addressed the issue by registering observer in `DefaultRemoteManager` with
`IpAddress.Any` in `WritableNetworkService`
JIRA:
[REEF-418](https://issues.apache.org/jira/browse/REEF-418)
Pull Request:
This closes #254
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/9c8fee2a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/9c8fee2a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/9c8fee2a
Branch: refs/heads/master
Commit: 9c8fee2a108eaeaffb87ce7d1ace53a5c0ef56bd
Parents: 474760f
Author: Dhruv <dh...@gmail.com>
Authored: Sat Jun 27 19:39:42 2015 -0700
Committer: Markus Weimer <we...@apache.org>
Committed: Sat Jun 27 22:16:07 2015 -0700
----------------------------------------------------------------------
.../NetworkService/WritableNetworkService.cs | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/9c8fee2a/lang/cs/Org.Apache.REEF.Network/NetworkService/WritableNetworkService.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Network/NetworkService/WritableNetworkService.cs b/lang/cs/Org.Apache.REEF.Network/NetworkService/WritableNetworkService.cs
index 834ced4..f383697 100644
--- a/lang/cs/Org.Apache.REEF.Network/NetworkService/WritableNetworkService.cs
+++ b/lang/cs/Org.Apache.REEF.Network/NetworkService/WritableNetworkService.cs
@@ -21,13 +21,10 @@ using System;
using System.Collections.Generic;
using System.Net;
using Org.Apache.REEF.Common.Io;
-using Org.Apache.REEF.Network.Naming;
-using Org.Apache.REEF.Network.NetworkService.Codec;
using Org.Apache.REEF.Tang.Annotations;
using Org.Apache.REEF.Tang.Exceptions;
using Org.Apache.REEF.Utilities.Logging;
using Org.Apache.REEF.Wake;
-using Org.Apache.REEF.Wake.Impl;
using Org.Apache.REEF.Wake.Remote;
using Org.Apache.REEF.Wake.Remote.Impl;
using Org.Apache.REEF.Wake.Util;
@@ -126,7 +123,8 @@ namespace Org.Apache.REEF.Network.NetworkService
NamingClient.Register(id.ToString(), _remoteManager.LocalEndpoint);
// Create and register incoming message handler
- var anyEndpoint = new IPEndPoint(_remoteManager.LocalEndpoint.Address, 0);
+ // TODO[REEF-419] This should use the TcpPortProvider mechanism
+ var anyEndpoint = new IPEndPoint(IPAddress.Any, 0);
_messageHandlerDisposable = _remoteManager.RegisterObserver(anyEndpoint, _messageHandler);
Logger.Log(Level.Info, "End of Registering id {0} with network service.", id);