You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by st...@hyperreal.org on 1999/10/12 03:09:55 UTC
cvs commit: apache-2.0/src/lib/apr/threadproc/win32 proc.c
stoddard 99/10/11 18:09:55
Modified: src/lib/apr aprlib.def
src/lib/apr/threadproc/win32 proc.c
Log:
I think this is an obsolete function...
Revision Changes Path
1.3 +1 -1 apache-2.0/src/lib/apr/aprlib.def
Index: aprlib.def
===================================================================
RCS file: /home/cvs/apache-2.0/src/lib/apr/aprlib.def,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- aprlib.def 1999/10/11 15:47:46 1.2
+++ aprlib.def 1999/10/12 01:09:54 1.3
@@ -113,7 +113,7 @@
ap_get_threadkeydata @105
ap_set_threadkeydata @106
ap_get_procdata @107
- ap_set_procdata @108
+; ap_set_procdata @108
ap_get_os_proc @109
ap_get_os_thread @110
ap_get_os_threadkey @111
1.7 +7 -7 apache-2.0/src/lib/apr/threadproc/win32/proc.c
Index: proc.c
===================================================================
RCS file: /home/cvs/apache-2.0/src/lib/apr/threadproc/win32/proc.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- proc.c 1999/10/11 17:52:20 1.6
+++ proc.c 1999/10/12 01:09:54 1.7
@@ -116,7 +116,7 @@
}
ap_status_t ap_setprocattr_dir(struct procattr_t *attr,
- char *dir)
+ const char *dir)
{
attr->currdir = ap_pstrdup(attr->cntxt, dir);
if (attr->currdir) {
@@ -139,14 +139,14 @@
return APR_SUCCESS;
}
-ap_status_t ap_create_process(struct proc_t **new, char *progname,
+ap_status_t ap_create_process(struct proc_t **new, const char *progname,
char *const args[], char **env,
struct procattr_t *attr, ap_context_t *cont)
{
int i, iEnvBlockLen;
- char *cmdline;
- HANDLE hCurrentProcess;
- HANDLE hParentindup, hParentoutdup,hParenterrdup;
+ char *cmdline;
+ HANDLE hCurrentProcess;
+ HANDLE hParentindup, hParentoutdup,hParenterrdup;
char ppid[20];
char *envstr;
char *pEnvBlock, *pNext;
@@ -348,7 +348,7 @@
return APR_ENOPROC;
}
}
-
+/*
ap_status_t ap_set_procdata(void *data, char *key,
ap_status_t (*cleanup) (void *)
struct proc_t *proc)
@@ -361,7 +361,7 @@
return APR_ENOPROC;
}
}
-
+*/
ap_status_t ap_get_os_proc(ap_os_proc_t *theproc, ap_proc_t *proc)
{
if (proc == NULL) {
Re: cvs commit: apache-2.0/src/lib/apr/threadproc/win32 proc.c
Posted by Bill Stoddard <st...@raleigh.ibm.com>.
> Why wuld ap_set_procdata be obsolete? We haven't used it anywhere yet,
> but it's purpose is still valid. Just like all the other set_foodata
> functions, it's purpose is to allow programmers to easily add their own
> data to APR types. This was a requested ability, and it should be left in
> the APR types.
Ahh, okay. I didn't see it in the unix/proc.c file and made an assumption.
I see now it is in unix/procsup.c rather than in proc.c.
Re: cvs commit: apache-2.0/src/lib/apr/threadproc/win32 proc.c
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
Why wuld ap_set_procdata be obsolete? We haven't used it anywhere yet,
but it's purpose is still valid. Just like all the other set_foodata
functions, it's purpose is to allow programmers to easily add their own
data to APR types. This was a requested ability, and it should be left in
the APR types.
Ryan
> Log:
> I think this is an obsolete function...
>
> Revision Changes Path
> 1.3 +1 -1 apache-2.0/src/lib/apr/aprlib.def
>
> Index: aprlib.def
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/lib/apr/aprlib.def,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- aprlib.def 1999/10/11 15:47:46 1.2
> +++ aprlib.def 1999/10/12 01:09:54 1.3
> @@ -113,7 +113,7 @@
> ap_get_threadkeydata @105
> ap_set_threadkeydata @106
> ap_get_procdata @107
> - ap_set_procdata @108
> +; ap_set_procdata @108
> ap_get_os_proc @109
> ap_get_os_thread @110
> ap_get_os_threadkey @111
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709 It's a beautiful sight to see good dancers
doing simple steps. It's a painful sight to
see beginners doing complicated patterns.