You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/24 23:13:26 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19008: Fix numpy equal broadcast
Zha0q1 opened a new pull request #19008:
URL: https://github.com/apache/incubator-mxnet/pull/19008
fixes https://github.com/apache/incubator-mxnet/issues/19006
Now this can run
``` python
import mxnet
from mxnet import np, npx
INT_OVERFLOW = 2**31
A = np.array([INT_OVERFLOW])
assert A == INT_OVERFLOW
assert INT_OVERFLOW == A
```
I also unskipped a test which will pass now give this fix.
local run:
```
ubuntu@ip-172-31-38-169:~/incubator-mxnet$ pytest tests/nightly/test_np_large_array.py::test_shape_array
/home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
return f(*args, **kwds)
/home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
return f(*args, **kwds)
/home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
return f(*args, **kwds)
==================================== test session starts =====================================
platform linux -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: /home/ubuntu/incubator-mxnet, inifile: pytest.ini
plugins: remotedata-0.3.2, openfiles-0.4.0, astropy-header-0.1.2, hypothesis-5.8.3, arraydiff-0.3, doctestplus-0.5.0
collected 1 item
tests/nightly/test_np_large_array.py . [100%]
===================================== 1 passed in 3.64s ======================================
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19008: Fix numpy equal broadcast
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19008:
URL: https://github.com/apache/incubator-mxnet/pull/19008#issuecomment-679574295
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19008: Fix numpy equal broadcast
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19008:
URL: https://github.com/apache/incubator-mxnet/pull/19008#issuecomment-679412050
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, unix-cpu, clang, unix-gpu, windows-gpu, centos-cpu, website, sanity, centos-gpu, windows-cpu, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19008: Fix numpy equal broadcast
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19008:
URL: https://github.com/apache/incubator-mxnet/pull/19008#issuecomment-680404200
thanks for the fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19008: Fix numpy equal broadcast
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19008:
URL: https://github.com/apache/incubator-mxnet/pull/19008#issuecomment-679574410
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19008: Fix numpy equal broadcast
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19008:
URL: https://github.com/apache/incubator-mxnet/pull/19008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org