You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/20 17:42:34 UTC
[GitHub] [apisix-website] barchielAbyss opened a new pull request, #1108: feat: website route (downloads, help, plugins, showcase) translation
barchielAbyss opened a new pull request, #1108:
URL: https://github.com/apache/apisix-website/pull/1108
🥳 this is last hard-coded in customized react template, appreciate everyone
Fixes: #[Add issue number here]
Changes:
added translation :
```
zh/showcase
zh/help
zh/downloads
zh/plugins
```
change json key, make sure the translation json order is the same as the file directory order
```
{
hero.webpage -> hero.component
arrowAnim.webpage -> arrowAnim.component
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] lijing-21 commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
lijing-21 commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1150614053
Hi @barchielAbyss , thanks for the contribution!
Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)
[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] hf400159 commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
hf400159 commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133515519
> what formatting tool do you use, can you recommend me?
cc @barchielAbyss ohh, for Chinese format detection in JSON files, I don't have a tool recommendation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133514369
> Can you fix the formatting problem first? 😆
oh, i'm sorry, because I set up my Vscode editor config:
``` json
{
"editor.formatOnSave": true,
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[typescriptreact]": {
"editor.defaultFormatter": "vscode.typescript-language-features"
},
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
}
```
what formatting tool do you use, can you recommend me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a diff in pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#discussion_r878635613
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on a diff in pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on code in PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#discussion_r878636040
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
Review Comment:
>
like `line 47`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] hf400159 commented on a diff in pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#discussion_r878630694
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
+ "description": "Incubating Archive repository"
+ },
+ "download.website.history.incubator": {
+ "message": " 存储着 Apache APISIX 旧版孵化器项目的备份归档，你也可以随时查阅它们。",
+ "description": " hosts older releases when APISIX was an incubator project."
+ },
+ "download.website.verify.title": {
+ "message": "验证 Apache APISIX 版本号",
Review Comment:
```suggestion
"message": "验证 Apache APISIX 版本",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
+ "description": "Incubating Archive repository"
+ },
+ "download.website.history.incubator": {
+ "message": " 存储着 Apache APISIX 旧版孵化器项目的备份归档，你也可以随时查阅它们。",
+ "description": " hosts older releases when APISIX was an incubator project."
+ },
+ "download.website.verify.title": {
+ "message": "验证 Apache APISIX 版本号",
+ "description": "Verify the releases"
+ },
+ "download.website.link.PGP_KEY": {
+ "message": "获取PGP签名密钥",
+ "description": "Get PGP signatures KEYS"
+ },
+ "download.website.verify.step1": {
+ "message": "你可以使用 PGP 或 SHA 签名验证 Apache APISIX 的文件完整性，使用 GPG 或 PGP 验证 PGP 签名的合法性， 建议从主目录获取密钥文件和ASC签名文件。",
Review Comment:
```suggestion
"message": "你可以使用 PGP 或 SHA 签名验证 Apache APISIX 的文件完整性，使用 GPG 或 PGP 验证 PGP 签名的合法性，建议从主目录获取密钥文件和 ASC 签名文件。",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
+ "description": "Incubating Archive repository"
+ },
+ "download.website.history.incubator": {
+ "message": " 存储着 Apache APISIX 旧版孵化器项目的备份归档，你也可以随时查阅它们。",
+ "description": " hosts older releases when APISIX was an incubator project."
+ },
+ "download.website.verify.title": {
+ "message": "验证 Apache APISIX 版本号",
+ "description": "Verify the releases"
+ },
+ "download.website.link.PGP_KEY": {
+ "message": "获取PGP签名密钥",
Review Comment:
```suggestion
"message": "获取 PGP 签名密钥",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
+ "description": "Incubating Archive repository"
+ },
+ "download.website.history.incubator": {
+ "message": " 存储着 Apache APISIX 旧版孵化器项目的备份归档，你也可以随时查阅它们。",
+ "description": " hosts older releases when APISIX was an incubator project."
+ },
+ "download.website.verify.title": {
+ "message": "验证 Apache APISIX 版本号",
+ "description": "Verify the releases"
+ },
+ "download.website.link.PGP_KEY": {
+ "message": "获取PGP签名密钥",
+ "description": "Get PGP signatures KEYS"
+ },
+ "download.website.verify.step1": {
+ "message": "你可以使用 PGP 或 SHA 签名验证 Apache APISIX 的文件完整性，使用 GPG 或 PGP 验证 PGP 签名的合法性， 建议从主目录获取密钥文件和ASC签名文件。",
+ "description": "It is essential that you verify the integrity of the downloaded files using the PGP or SHA signatures. The PGP signatures can be verified using GPG or PGP. Please download the KEYS as well as the asc signature files for relevant distribution. It is recommended to get these files from the main distribution directory and not from the mirrors."
+ },
+ "download.website.verify.step2": {
+ "message": "如果需要验证二进制文件/源代码，您可以从主目录下载相关的 asc 文件，并遵循下面的指南。",
Review Comment:
```suggestion
"message": "如果需要验证二进制文件/源代码，您可以从主目录下载相关的 ACS 文件，并遵循下面的指南。",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a diff in pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#discussion_r878634310
##########
website/i18n/zh/code.json:
##########
@@ -3,29 +3,21 @@
"message": "。",
"description": "."
},
- "hero.webpage.title.fragment1": {
- "message": "简单高效的",
- "description": "Effortless and smooth"
- },
- "hero.webpage.title.fragment2": {
- "message": "API 流量",
- "description": "API Traffic"
- },
- "hero.webpage.title.fragment3": {
- "message": "管理组件",
- "description": "management"
+ "showcase.website.title": {
+ "message": "产品展示",
+ "description": "Showcase"
},
- "hero.webpage.subtitle.content": {
- "message": "Apache APISIX 是一个动态、实时、高性能的云原生 API 网关，提供了负载均衡、动态上游、灰度发布、服务熔断、身份认证、可观测性等丰富的流量管理功能。",
- "description": "Apache APISIX provides rich traffic management features like Load Balancing, Dynamic Upstream, Canary Release, Circuit Breaking, Authentication, Observability, and more..."
+ "showcase.website.tips.used": {
+ "message": "他们都在使用 Apache APISIX 进行生产和研究",
Review Comment:
```suggestion
"message": "Apache APISIX 被众多产品与用户所信赖",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
Review Comment:
```suggestion
"message": "历史版本归档",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
Review Comment:
```suggestion
"message": "孵化时的历史版本",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
Review Comment:
```suggestion
"message": "We love Open Source.",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
+ "description": "Incubating Archive repository"
+ },
+ "download.website.history.incubator": {
+ "message": " 存储着 Apache APISIX 旧版孵化器项目的备份归档，你也可以随时查阅它们。",
+ "description": " hosts older releases when APISIX was an incubator project."
+ },
+ "download.website.verify.title": {
+ "message": "验证 Apache APISIX 版本号",
+ "description": "Verify the releases"
+ },
+ "download.website.link.PGP_KEY": {
+ "message": "获取PGP签名密钥",
+ "description": "Get PGP signatures KEYS"
+ },
+ "download.website.verify.step1": {
+ "message": "你可以使用 PGP 或 SHA 签名验证 Apache APISIX 的文件完整性，使用 GPG 或 PGP 验证 PGP 签名的合法性， 建议从主目录获取密钥文件和ASC签名文件。",
+ "description": "It is essential that you verify the integrity of the downloaded files using the PGP or SHA signatures. The PGP signatures can be verified using GPG or PGP. Please download the KEYS as well as the asc signature files for relevant distribution. It is recommended to get these files from the main distribution directory and not from the mirrors."
+ },
+ "download.website.verify.step2": {
+ "message": "如果需要验证二进制文件/源代码，您可以从主目录下载相关的 asc 文件，并遵循下面的指南。",
+ "description": "To verify the binaries/sources you can download the relevant asc files for it from main distribution directory and follow the below guide."
+ },
+ "help.website.title": {
+ "message": "需要帮助吗？",
Review Comment:
```suggestion
"message": "获取帮助",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
Review Comment:
```suggestion
"message": "立即下载",
```
##########
website/i18n/zh/code.json:
##########
@@ -3,29 +3,21 @@
"message": "。",
"description": "."
},
- "hero.webpage.title.fragment1": {
- "message": "简单高效的",
- "description": "Effortless and smooth"
- },
- "hero.webpage.title.fragment2": {
- "message": "API 流量",
- "description": "API Traffic"
- },
- "hero.webpage.title.fragment3": {
- "message": "管理组件",
- "description": "management"
+ "showcase.website.title": {
+ "message": "产品展示",
Review Comment:
```suggestion
"message": "用户列表",
```
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
+ "description": "Incubating Archive repository"
+ },
+ "download.website.history.incubator": {
+ "message": " 存储着 Apache APISIX 旧版孵化器项目的备份归档，你也可以随时查阅它们。",
+ "description": " hosts older releases when APISIX was an incubator project."
+ },
+ "download.website.verify.title": {
+ "message": "验证 Apache APISIX 版本号",
+ "description": "Verify the releases"
+ },
+ "download.website.link.PGP_KEY": {
+ "message": "获取PGP签名密钥",
+ "description": "Get PGP signatures KEYS"
+ },
+ "download.website.verify.step1": {
+ "message": "你可以使用 PGP 或 SHA 签名验证 Apache APISIX 的文件完整性，使用 GPG 或 PGP 验证 PGP 签名的合法性， 建议从主目录获取密钥文件和ASC签名文件。",
+ "description": "It is essential that you verify the integrity of the downloaded files using the PGP or SHA signatures. The PGP signatures can be verified using GPG or PGP. Please download the KEYS as well as the asc signature files for relevant distribution. It is recommended to get these files from the main distribution directory and not from the mirrors."
+ },
+ "download.website.verify.step2": {
+ "message": "如果需要验证二进制文件/源代码，您可以从主目录下载相关的 asc 文件，并遵循下面的指南。",
+ "description": "To verify the binaries/sources you can download the relevant asc files for it from main distribution directory and follow the below guide."
+ },
+ "help.website.title": {
+ "message": "需要帮助吗？",
+ "description": "NEED HELP?"
+ },
+ "help.website.subtitle": {
+ "message": "维护 Apache APISIX 的专业团队人员随时可以为你答疑解惑",
Review Comment:
```suggestion
"message": "Apache APISIX 维护者们将积极为你答疑解惑",
```
##########
website/i18n/zh/code.json:
##########
@@ -3,29 +3,21 @@
"message": "。",
"description": "."
},
- "hero.webpage.title.fragment1": {
- "message": "简单高效的",
- "description": "Effortless and smooth"
- },
- "hero.webpage.title.fragment2": {
- "message": "API 流量",
- "description": "API Traffic"
- },
- "hero.webpage.title.fragment3": {
- "message": "管理组件",
- "description": "management"
+ "showcase.website.title": {
+ "message": "产品展示",
+ "description": "Showcase"
},
- "hero.webpage.subtitle.content": {
- "message": "Apache APISIX 是一个动态、实时、高性能的云原生 API 网关，提供了负载均衡、动态上游、灰度发布、服务熔断、身份认证、可观测性等丰富的流量管理功能。",
- "description": "Apache APISIX provides rich traffic management features like Load Balancing, Dynamic Upstream, Canary Release, Circuit Breaking, Authentication, Observability, and more..."
+ "showcase.website.tips.used": {
+ "message": "他们都在使用 Apache APISIX 进行生产和研究",
+ "description": "This project is used by all these folks"
},
- "hero.webpage.download.btn": {
- "message": "立即体验",
- "description": "Download"
+ "showcase.website.tips.wantUse": {
+ "message": "你也在使用它吗？告诉我们是如何使用，我们将会积极的收集和采纳你的意见。",
Review Comment:
```suggestion
"message": "你也在使用它吗？请让我们知道！",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133616891
> > Can you fix the formatting problem first? 😆
>
> Oh, i'm sorry, because I set up my Vscode editor config:
>
> ```json
> {
> "editor.formatOnSave": true,
> "[javascript]": {
> "editor.defaultFormatter": "esbenp.prettier-vscode"
> },
> "[typescriptreact]": {
> "editor.defaultFormatter": "vscode.typescript-language-features"
> },
> "[json]": {
> "editor.defaultFormatter": "esbenp.prettier-vscode"
> }
> }
> ```
>
> what formatting tool do you use, can you recommend me?
We are using eslint, although it is not strictly a formatting tool. For some reason I don't use strict configuration, so it has a lot of problems. If you follow the readme I wrote and install the appropriate dependencies, eslint should help you with some of the formatting issues by husky calling it before you commit. If there are some deficiencies or problems with our configuration, you are welcome to help us improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133516935
> > what formatting tool do you use, can you recommend me?
> > cc @barchielAbyss ohh, for Chinese format detection in JSON files, I don't have a tool recommendation.
What you want to say should be: *this commit does two things, which is not good, they should be done separately*
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on a diff in pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on code in PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#discussion_r878636016
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
Review Comment:
>
I think the link of the **file repository** should not be translated directly.
The file repository **path** or **name** corresponds to English, which may cause trouble for developers after translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] github-actions[bot] commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133170540
<!-- NETLIFY DEPLOY COMMENT GENERATED BY ACTIONS_NETLIFY - APP ID SHA256: 4a1e2936f4b00e970c8b5babdfe5b33e6e83e97b6f6d6dda75b1fe8399056321 -->
🚀 Deployed on https://6287d54a3ba32212135f05a5--apache-apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on a diff in pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on code in PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#discussion_r878635041
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
Review Comment:
I think the link of the **file repository** should not be translated directly.
The file repository **path** and **title** corresponds to English, which may cause trouble for developers after translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a diff in pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#discussion_r878648627
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133159986
### <span aria-hidden="true">👷</span> Deploy request for *apache-apisix* pending review.
[Visit the deploys page to approve it](https://app.netlify.com/sites/apache-apisix/deploys)
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 91dbaf82a2685d2e27b755cf2ca48649c6e5dfec |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133170796
@SkyeYoung
hi, if u have a litte times, please check this issue, i want add A new component 2 fix this. in before time, i'm written Vue component [Affix](https://fe.xiaoman.cn/amumu/components/affix.html), i want write React version component for after time.
https://github.com/apache/apisix-website/issues/1107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] barchielAbyss commented on a diff in pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
barchielAbyss commented on code in PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#discussion_r878635041
##########
website/i18n/zh/code.json:
##########
@@ -35,6 +27,86 @@
"message": "让产品与技术背后的细节更加可视化",
"description": "We love open source."
},
+ "download.website.title": {
+ "message": "开启智能网关之旅",
+ "description": "Downloads"
+ },
+ "download.website.subtitle": {
+ "message": "We love open source.",
+ "description": "We love open source."
+ },
+ "download.website.history.title": {
+ "message": "历史版本",
+ "description": "History Versions"
+ },
+ "download.website.history.all": {
+ "message": "如果你想要预览 Apache APISIX 已发布的所有版本，请查看 ",
+ "description": "Find all APISIX releases in the "
+ },
+ "download.website.link.archive": {
+ "message": "Archive repository",
+ "description": "Archive repository"
+ },
+ "download.website.link.incubator": {
+ "message": "Incubating Archive repository",
Review Comment:
I think the link of the **file repository** should not be translated directly.
The file repository **path** and **title** corresponds to English, which may cause trouble for developers after translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on pull request #1108: feat: website route (downloads, help, plugins, showcase) translation
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on PR #1108:
URL: https://github.com/apache/apisix-website/pull/1108#issuecomment-1133624126
> What you want to say should be: _this commit does two things, which is not good, they should be done separately_
I'm working on a solution regarding the formatting of mixed Chinese and English, but I haven't had time to test it and actually use it for this project yet.
As a temporary solution, you can use zhlint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org