You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/05 13:57:25 UTC

[GitHub] [incubator-devlake-website] Startrekzky commented on a diff in pull request #373: doc: update data source increment for github

Startrekzky commented on code in PR #373:
URL: https://github.com/apache/incubator-devlake-website/pull/373#discussion_r1062498646


##########
docs/Overview/SupportedDataSources.md:
##########
@@ -121,24 +121,24 @@ This table shows the entities collected by each plugin. Domain layer entities in
 | Subtask Name                       | Estimated Max Number of Request | Does It support Incremental Collection? | Does It Support Time Filter? |
 | ---------------------------------- | ------------------------------- | --------------------------------------- | ---------------------------- |
 | ---------------------------------  | Common                          | -----------------------                 |                              |
-| CollectMilestonesMeta              | ≈10                             | ✅                                      | ❌                           |
-| CollectRunsMeta                    | <10^4                           | ❌                                      | ✅                           |
-| CollectApiCommentsMeta             | 400 (max page github supported) | ✅                                      | ❌                           |
-| **CollectApiEventsMeta**           | 400 (max page github supported) | ❌                                      | ❌                           |
-| CollectApiPullRequestReviewsMeta   | <10^5                           | ✅                                      | ✅                           |
+| CollectMilestonesMeta              | ≈10                             | ✅                                       | ❌                            |
+| CollectRunsMeta                    | <10^4                           | ✅                                       | ✅                            |
+| CollectApiCommentsMeta             | 400 (max page github supported) | ✅                                       | ✅                            |
+| **CollectApiEventsMeta**           | 400 (max page github supported) | ❌                                       | ❌                            |
+| CollectApiPullRequestReviewsMeta   | <10^5                           | ✅                                       | ✅                            |
 | ---------------------------------  | Graphql Only (Default)          | -----------------------                 |                              |
-| CollectIssueMeta                   | ≈10^4                           | ❌                                      | ✅                           |
-| CollectPrMeta                      | ≈10^3                           | ❌                                      | ✅                           |
-| CollectCheckRunMeta                | <10^4                           | ❌                                      | ✅                           |
-| CollectAccountMeta                 | ≈10^2                           | ❌                                      | -                            |
+| CollectIssueMeta                   | ≈10^4                           | ❌                                       | ✅                            |
+| CollectPrMeta                      | ≈10^3                           | ❌                                       | ✅                            |
+| CollectCheckRunMeta                | <10^4                           | ❌                                       | ✅                            |
+| CollectAccountMeta                 | ≈10^2                           | ❌                                       | -                            |
 | ---------------------------------  | Restful Only (Not Default)      | -----------------------                 |                              |

Review Comment:
   Not by default?



##########
docs/Overview/SupportedDataSources.md:
##########
@@ -121,24 +121,24 @@ This table shows the entities collected by each plugin. Domain layer entities in
 | Subtask Name                       | Estimated Max Number of Request | Does It support Incremental Collection? | Does It Support Time Filter? |
 | ---------------------------------- | ------------------------------- | --------------------------------------- | ---------------------------- |
 | ---------------------------------  | Common                          | -----------------------                 |                              |
-| CollectMilestonesMeta              | ≈10                             | ✅                                      | ❌                           |
-| CollectRunsMeta                    | <10^4                           | ❌                                      | ✅                           |
-| CollectApiCommentsMeta             | 400 (max page github supported) | ✅                                      | ❌                           |
-| **CollectApiEventsMeta**           | 400 (max page github supported) | ❌                                      | ❌                           |
-| CollectApiPullRequestReviewsMeta   | <10^5                           | ✅                                      | ✅                           |
+| CollectMilestonesMeta              | ≈10                             | ✅                                       | ❌                            |
+| CollectRunsMeta                    | <10^4                           | ✅                                       | ✅                            |
+| CollectApiCommentsMeta             | 400 (max page github supported) | ✅                                       | ✅                            |

Review Comment:
   max page that GitHub supports



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org