You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@activemq.apache.org by soe <co...@gmx.com> on 2013/12/20 13:29:13 UTC

ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Hi all,

I've start a activemq broker, configured with amqp connector. On the other
hand, I've a Qpid amqp client which send message to the broker. If I let the
sender close the connection by himself (producer, session & connection), I
see on hawtio admin interface that connection isn't fully close. The broker
holds open the tcp connection.

I've not found any information about these behavior in the hole net :-(
Have anybody any idea what happens and what can I do, that the broker fully
close the connection.

I've also tried to set transport.connectionTimeout or soTime within the
connector URI within broker configuration. But nothing helps.

Thanks for help. 



--
View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756.html
Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Posted by "tabish121@gmail.com" <ta...@gmail.com>.
I created a test case that shows the issue and opened a new Jira issue to
track the progress.
https://issues.apache.org/jira/browse/AMQ-4962




--
View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756p4676058.html
Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Posted by soe <co...@gmx.com>.
Hi all,

thanks for all of your help and fixes.
Sry I'm on vacation and afterwards I'm sick :-(

I'll will try the fix also, but not yet. Our implementation is switched to
"normal" JMS for now.

Thanks a lot of your fast help and reply.




--
View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756p4676869.html
Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Posted by uromahn <ul...@ulrichromahn.net>.
I got the latest sources, build 5.10-SNAPSHOT and tested it - everything
seems ok now.
THANK YOU!

After looking at your fix, I decided to back-port this also to 5.9.0 (which
we are going to use until 5.10 becomes final) by simply copying the single
changed file AmqpProtocolConverter.java into the 5.9.0 sources and re-build.
With that step, I am also getting another fix that was applied to the
AmqpProtocolConverter after 5.9.0 and my own tests show that this also fixed
the issue (of lingering connections) with 5.9.0.

So, I am a "very happy camper" now - thanks again!



--
View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756p4676089.html
Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Posted by "tabish121@gmail.com" <ta...@gmail.com>.
This is now fixed on trunk, use the latest 0.26-SNAPSHOT of QPid client for
best results. 



--
View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756p4676063.html
Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Posted by uromahn <ul...@ulrichromahn.net>.
As promised in my last post, I re-tested this using the latest SNAPSHOT
versions of all involved components.
I built ActiveMQ 5.10-SNAPSHOT from source with qpid-proton-j-0.6-SNAPSHOT
and the latest amqp-1-0-client-jms-0.26-SNAPSHOT (or 0.28-SNAPSHOT,
depending on how one builds it).

The result is exactly the same: after the client closes the connection to
the broker (via AMQP), the broker holds that connection open indefinitely,
unless you close it explicitly on the Hawtio console.

I am a bit busy with my work right now, but I take a look at it in case I
can find some spare time.

-Uli



--
View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756p4676053.html
Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Posted by uromahn <ul...@ulrichromahn.net>.
Quick update on my previous post:

I just looked at the ActiveMQ 5.10-SNAPSHOT pom.xml and saw that it still
depends on proton-j 0.5 and qpid-jms 0.24. So I am pretty sure that the same
issue still exists.

I will play around with 5.10-SNAPSHOT and "upgrade" to the latest SNAPSHOT
versions of those two to see if the issue has been fixed (which I honestly
doubt as well).

-Uli



--
View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756p4676003.html
Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Posted by uromahn <ul...@ulrichromahn.net>.
I have seen the exact same behavior.

I have actually initiated the patch for the latest amqp-1-0-client-jms
library. It fixed one issue on the client but the connection still stays
open on ActiveMQ.

According to Rob Godfrey (from the Qpid project) there is a potential issue
in proton-c and also proton-j - the jms client is closing the connection
without detaching from the session and hence the server seems to keep the
connection open for a potential re-connect and resume of the session.

I have not yet tested it with 5.10-SNAPSHOT which is supposed to use a
proton-j-0.6-SNAPSHOT to see if it is fixed there. I can do that during the
next few days and can update this post with my findings.

-Uli



--
View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756p4676002.html
Sent from the ActiveMQ - User mailing list archive at Nabble.com.

Re: ActiveMQ broker 5.9 doesn't close TCP connection if qpid client close amqp connection

Posted by Timothy Bish <ta...@gmail.com>.
On 12/20/2013 07:29 AM, soe wrote:
> Hi all,
>
> I've start a activemq broker, configured with amqp connector. On the other
> hand, I've a Qpid amqp client which send message to the broker. If I let the
> sender close the connection by himself (producer, session & connection), I
> see on hawtio admin interface that connection isn't fully close. The broker
> holds open the tcp connection.
>
> I've not found any information about these behavior in the hole net :-(
> Have anybody any idea what happens and what can I do, that the broker fully
> close the connection.
>
> I've also tried to set transport.connectionTimeout or soTime within the
> connector URI within broker configuration. But nothing helps.
>
> Thanks for help.
>
>
>
> --
> View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-broker-5-9-doesn-t-close-TCP-connection-if-qpid-client-close-amqp-connection-tp4675756.html
> Sent from the ActiveMQ - User mailing list archive at Nabble.com.
>
First thing to try would be a 5.10-SNAPSHOT as we've fixed a bunch of 
stuff.  Also there's a 0.26-SNAPSHOT of the QPid JMS client that has 
many, many fixes.

-- 
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.bish@redhat.com | www.fusesource.com | www.redhat.com
skype: tabish121 | twitter: @tabish121
blog: http://timbish.blogspot.com/