You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/29 17:52:56 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #183: Travis CI
configuration
yamt opened a new pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #183: Travis
CI configuration
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-595077818
Let's track CI issue by:
https://github.com/apache/incubator-nuttx/pull/261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #183:
Travis CI configuration
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r374500824
##########
File path: .travis.yml
##########
@@ -0,0 +1,17 @@
+sudo: required
Review comment:
i added apache license to this file too as this yaml file contains shell script snippets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #183:
Travis CI configuration
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373917529
##########
File path: boards/sim/sim/sim/configs/ostest/defconfig
##########
@@ -10,10 +10,12 @@ CONFIG_ARCH_BOARD="sim"
CONFIG_ARCH_BOARD_SIM=y
Review comment:
this change is required by other changes as otherwise ./nuttx just hangs after running the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#183: Travis CI configuration
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373587235
##########
File path: boards/sim/sim/sim/configs/ostest/defconfig
##########
@@ -10,10 +10,12 @@ CONFIG_ARCH_BOARD="sim"
CONFIG_ARCH_BOARD_SIM=y
Review comment:
This change seems out of place with the other commits in the PR. Perhaps it should be a separate PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #183:
Travis CI configuration
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r375083047
##########
File path: tools/travis/travis.sh
##########
@@ -0,0 +1,46 @@
+#! /bin/sh
Review comment:
i added apache license
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-581234071
i added apache license to shell scripts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-580817548
What is the harm in merging this to see how well it works. Is it not completely over low-risk?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#183: Travis CI configuration
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373588071
##########
File path: .travis.yml
##########
@@ -0,0 +1,17 @@
+sudo: required
Review comment:
Question: Do .yml files require licenses and headers? I would think the answer is YES. ??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-579880151
This would have caught a recent bug: https://github.com/apache/incubator-nuttx/pull/181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #183: Travis
CI configuration
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#183: Travis CI configuration
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373588071
##########
File path: .travis.yml
##########
@@ -0,0 +1,17 @@
+sudo: required
Review comment:
Question: Do .yml files require licenses and headers? I would think the answer is YES. ??
I think that basically any that "executes" needs a license header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-582827224
any takers? eventually i want to add windows build which i can't test locally. i guess it's possible as travis ci provides windows env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-579881916
This patch is the step 4, 5 of https://docs.travis-ci.com/user/tutorial/#to-get-started-with-travis-ci
Someone with permission on this repo can do the step 1, 2, 3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] justinmclean commented on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
justinmclean commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-581114694
ASF policy on headers is reasonable clear [1], but if in doubt add a header. BSD headers should not be added to new files ASF ALv2 headers should be used.
1. https://www.apache.org/legal/src-headers.html#headers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] maht commented on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
maht commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-582844211
I think is great to have this code available, but maybe it should be placed in `incubator-nuttx-testing`, as requested by @patacongo [1] and others.
Maybe this preference of a separate repo for the CI code is not settled on stone and it can be reconsidered, but other people then will require to put their own scripts on main repo.
Can the CircleCI script be rewritten to clone the testing repo and move the logic there? I know maybe is a PITA to move it, but maybe would be easier to be accepted, and that is what I have been doing for other CI scripts, like the Jenkins one I have under review in that repo: put a "placeholder" Jenkinsfile in main repo so the CI can "hook" to it and the actual logic in the testing one.
[1] https://www.mail-archive.com/dev@nuttx.apache.org/msg00436.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #183: Travis
CI configuration
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-579886780
> This patch is the step 4, 5 of https://docs.travis-ci.com/user/tutorial/#to-get-started-with-travis-ci
> Someone with permission on this repo can do the step 1, 2, 3.
We have to use Jenkins and server from Apache to conform Apache requirement:
https://github.com/apache/incubator-nuttx/pull/174
If you are interesting in setup the automation build and test, @liuguo09, @maht and you can work together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #183:
Travis CI configuration
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-582984912
Hi @yamt , @liuguo09 will look this patch and try to integrate with cibuild.sh. Since github could:
1.Provide Linux/MacOS/Windows VM
2.The computing power is better than Apache
3.Integrate with the workflow smoothly
We are considering using github as PR check and apache as nightly build. @liuguo09 will send the current state and plan to dev@nuttx.apache.org for furture discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #183:
Travis CI configuration
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-582984912
Hi @yamt , @liuguo09 will look this patch and try to integrate with cibuild.sh. Since github could:
1.Provide Linux/MacOS/Windows VM
2.The computing power is better than Apache
3.Integrate with the workflow smoothly
We are considering using github as PR check and apache as nightly build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 edited a comment on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-580817548
What is the harm in merging this to see how well it works. Is it not completely low-risk?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#183: Travis CI configuration
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#discussion_r373587818
##########
File path: tools/travis/travis.sh
##########
@@ -0,0 +1,46 @@
+#! /bin/sh
Review comment:
PLEASE FIX: All .sh files reequire (currently) a BSD 3-clause license. No unlicensed shell scripts may come in.
(License will, eventually, be changed to Apache).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #183: Travis
CI configuration
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-582984912
Hi @yamt , @liuguo09 will look this patch and try to integrate with cibuild.sh.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #183:
Travis CI configuration
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-579886780
> This patch is the step 4, 5 of https://docs.travis-ci.com/user/tutorial/#to-get-started-with-travis-ci
> Someone with permission on this repo can do the step 1, 2, 3.
We have to use Jenkins and server from Apache to conform Apache requirement:
https://github.com/apache/incubator-nuttx/pull/174
If you are interesting in setup the automation build and test, @liuguo09, @maht and you can work together.
Also, per the discussion, all CI related stuff is put here:
https://github.com/apache/incubator-nuttx-testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #183: Travis CI
configuration
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #183: Travis CI configuration
URL: https://github.com/apache/incubator-nuttx/pull/183#issuecomment-579888073
even if you don't activate it on this repo, this is convenient for people working on their fork on github.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services