You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Du Li <li...@gmail.com> on 2013/11/01 04:18:36 UTC
Re: Review Request 14963: implementation of CLI mesos-upload
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14963/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 3:18 a.m.)
Review request for mesos, Benjamin Hindman and Jason Dusek.
Changes
-------
This diff mainly addresses the Popen arguments issue as recommended by Jason Dusek. In addition, it also fixes a few python style issues.
Repository: mesos-git
Description
-------
This commit implements a new CLI command mesos-upload, which upload specified local file(s) to a specified directory on all slaves as defined in the var/mesos/deploy/slaves file. This version is based on command "rsync". Its efficiency could be improved later when the number of slaves goes large, e.g., by dynamically organize the slaves into a tree.
Diffs (updated)
-----
src/cli/mesos-upload PRE-CREATION
Diff: https://reviews.apache.org/r/14963/diff/
Testing
-------
Need to be tested on a real cluster.
Thanks,
Du Li
Re: Review Request 14963: implementation of CLI mesos-upload
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14963/#review28722
-----------------------------------------------------------
Ship it!
Hm.. the diff on this one shows the file already exists?
- Ben Mahler
On Nov. 1, 2013, 3:18 a.m., Du Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14963/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 3:18 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jason Dusek.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This commit implements a new CLI command mesos-upload, which upload specified local file(s) to a specified directory on all slaves as defined in the var/mesos/deploy/slaves file. This version is based on command "rsync". Its efficiency could be improved later when the number of slaves goes large, e.g., by dynamically organize the slaves into a tree.
>
>
> Diffs
> -----
>
> src/cli/mesos-upload PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14963/diff/
>
>
> Testing
> -------
>
> Need to be tested on a real cluster.
>
>
> Thanks,
>
> Du Li
>
>
Re: Review Request 14963: implementation of CLI mesos-upload
Posted by Du Li <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14963/
-----------------------------------------------------------
(Updated Nov. 20, 2013, 11:03 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Shingo Omura.
Changes
-------
This diff changes the implementation of upload from rsync to scp using futures + subprocess.Popen, as discussed in Hackathon 11/19 with Ben Hindman. Also the CLI name is changed from mesos-upload to mesos-scp.
Repository: mesos-git
Description
-------
This commit implements a new CLI command mesos-upload, which upload specified local file(s) to a specified directory on all slaves as defined in the var/mesos/deploy/slaves file. This version is based on command "rsync". Its efficiency could be improved later when the number of slaves goes large, e.g., by dynamically organize the slaves into a tree.
Diffs (updated)
-----
src/cli/mesos-scp PRE-CREATION
Diff: https://reviews.apache.org/r/14963/diff/
Testing
-------
has been tested on a local cluster of 12 servers.
Thanks,
Du Li
Re: Review Request 14963: implementation of CLI mesos-upload
Posted by Du Li <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14963/
-----------------------------------------------------------
(Updated Nov. 16, 2013, 12:59 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Shingo Omura.
Changes
-------
This diff implements CLI mesos-upload, which uploads specified local file(s) to a specified directory on all slaves as defined in the var/mesos/deploy/slaves configuration file. This version is based command "scp", assuming that password-less ssh has been set up on current mesos cluster. Its efficiency could be improved later when the number of slaves goes large.
Repository: mesos-git
Description
-------
This commit implements a new CLI command mesos-upload, which upload specified local file(s) to a specified directory on all slaves as defined in the var/mesos/deploy/slaves file. This version is based on command "rsync". Its efficiency could be improved later when the number of slaves goes large, e.g., by dynamically organize the slaves into a tree.
Diffs (updated)
-----
src/cli/mesos-upload PRE-CREATION
Diff: https://reviews.apache.org/r/14963/diff/
Testing (updated)
-------
has been tested on a local cluster of 12 servers.
Thanks,
Du Li