You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by "Ferdy (Created) (JIRA)" <ji...@apache.org> on 2011/10/24 09:44:32 UTC
[jira] [Created] (GORA-56) HBaseStore is not thread safe.
HBaseStore is not thread safe.
------------------------------
Key: GORA-56
URL: https://issues.apache.org/jira/browse/GORA-56
Project: Gora
Issue Type: Bug
Components: storage-hbase
Reporter: Ferdy
Priority: Critical
Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Ferdy Galema (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142002#comment-13142002 ]
Ferdy Galema commented on GORA-56:
----------------------------------
Thanks for the review.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GORA-56) HBaseStore is not thread safe.
Posted by "Ferdy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy updated GORA-56:
----------------------
Attachment: GORA-56.patch
Finished patch. The code itself is documented. The most important part is that it abstracts the thread safeness from the main Store class in order to keep it maintainable. It uses a ThreadLocal construct. Also it modifies some components (HbaseMapping) into thread safe ones. Because it is still a fairly large patch, I tried to minimize the changes so that it does not attempt to address anything else besides making it thread safe.
Feel free to comment.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy
> Priority: Critical
> Attachments: GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Enis Soztutar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151833#comment-13151833 ]
Enis Soztutar commented on GORA-56:
-----------------------------------
bq. Finally, Enis can you please comment on what type of issues you consider as over and above what this patch addresses. Maybe it would be best at this stage to get them documented as I believe Ferdy is going away for a while just now. Thank you
The DataStore's should be thread safe by definition, but most of them aren't. This patch makes the HBaseStore thread-safe by localizing the HTable instances to be thread-local.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Enis Soztutar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141340#comment-13141340 ]
Enis Soztutar commented on GORA-56:
-----------------------------------
With the implementation in patch, I did not expect a major performance impact, but just wanted to double check with you. Most of the current data store code assume that it is not thread safe, so we should fix those cases as well if needed. Other than that, we can go ahead with this patch.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GORA-56) HBaseStore is not thread safe.
Posted by "Ferdy Galema (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy Galema updated GORA-56:
-----------------------------
Attachment: GORA-56-v3.patch
Good one, uploaded new version of patch with Apache header added.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Enis Soztutar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140381#comment-13140381 ]
Enis Soztutar commented on GORA-56:
-----------------------------------
Patch looks good. Have you profiled the implementation? I wonder, with only a single thread and local HBase deployment, whether there is a performance impact.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Ferdy (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141046#comment-13141046 ]
Ferdy commented on GORA-56:
---------------------------
I ran some benchmarks for the patch in single thread mode and I could not notice a performance impact compared to the current implementation. This is to be expected:
-The ThreadLocal HTable code should not incur a performance penalty. It is a recommended way to avoid synchronization altogether.
-The fields in HBaseStore are made volatile, however since there are just written once and read only afterwards the penalty for this is truly minimal.
Removing the volatile keywords will not make a difference in practice, but technically they are required since the initialization thread must publish its objects safely to other threads somehow. (However I probably could have gotten away with using just one volatile variable as a memory-barrier.) Anyway I noticed that some of the other store implementations (including superclass DataStoreBase) do not do any of this, so I guess this is something to keep in mind.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Henry Saputra (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143526#comment-13143526 ]
Henry Saputra commented on GORA-56:
-----------------------------------
+1
Small nit to add ASF license header to the HBaseTableConnection.java file
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Lewis John McGibbney (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151990#comment-13151990 ]
Lewis John McGibbney commented on GORA-56:
------------------------------------------
Yes I have the rights. If this is OK with folks I'll commit the one today. Thanks for comments and Ferdy for patch.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152669#comment-13152669 ]
Hudson commented on GORA-56:
----------------------------
Integrated in gora-trunk #42 (See [https://builds.apache.org/job/gora-trunk/42/])
commit to address GORA-56, update to changes.txt and thank you to Ferdy
lewismc : http://svn.apache.org/viewvc/incubator/gora/trunk/viewvc/?view=rev&root=&revision=1203184
Files :
* /incubator/gora/trunk/CHANGES.txt
* /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseColumn.java
* /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseMapping.java
* /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
* /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseTableConnection.java
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Assignee: Lewis John McGibbney
> Priority: Critical
> Fix For: 0.2-incubating
>
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Lewis John McGibbney (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151266#comment-13151266 ]
Lewis John McGibbney commented on GORA-56:
------------------------------------------
Finally, Enis can you please comment on what type of issues you consider as over and above what this patch addresses. Maybe it would be best at this stage to get them documented as I believe Ferdy is going away for a while just now. Thank you
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Ferdy Galema (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152011#comment-13152011 ]
Ferdy Galema commented on GORA-56:
----------------------------------
Thanks guys.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Chris A. Mattmann (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151757#comment-13151757 ]
Chris A. Mattmann commented on GORA-56:
---------------------------------------
Hey Guys, Lewis should have karma...let me know if he doesn't.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152645#comment-13152645 ]
Hudson commented on GORA-56:
----------------------------
Integrated in gora-trunk-ant #35 (See [https://builds.apache.org/job/gora-trunk-ant/35/])
commit to address GORA-56, update to changes.txt and thank you to Ferdy
lewismc : http://svn.apache.org/viewvc/incubator/gora/trunk/viewvc/?view=rev&root=&revision=1203184
Files :
* /incubator/gora/trunk/CHANGES.txt
* /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseColumn.java
* /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseMapping.java
* /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
* /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseTableConnection.java
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Assignee: Lewis John McGibbney
> Priority: Critical
> Fix For: 0.2-incubating
>
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GORA-56) HBaseStore is not thread safe.
Posted by "Lewis John McGibbney (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lewis John McGibbney reassigned GORA-56:
----------------------------------------
Assignee: Lewis John McGibbney
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Assignee: Lewis John McGibbney
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Ferdy Galema (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151250#comment-13151250 ]
Ferdy Galema commented on GORA-56:
----------------------------------
I can verify that we did not run into any issues with this patch enabled for several weeks now.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GORA-56) HBaseStore is not thread safe.
Posted by "Ferdy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy updated GORA-56:
----------------------
Attachment: GORA-56-v2.patch
Very small update to the patch: forgot to make a field in HBaseMapping final.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Ferdy (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137370#comment-13137370 ]
Ferdy commented on GORA-56:
---------------------------
Just to add on my testing method, this is the same as in GORA-48 (using Nutch TestGoraStorage). Writing multithreaded to the store works with the patch, without the patch it fails with several (IndexOutOfBounds) exceptions.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy
> Priority: Critical
> Attachments: GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Lewis John McGibbney (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151264#comment-13151264 ]
Lewis John McGibbney commented on GORA-56:
------------------------------------------
Ping this one Ferdy. Henry and myself give you the thumbs up. Thank you
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GORA-56) HBaseStore is not thread safe.
Posted by "Henry Saputra (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151738#comment-13151738 ]
Henry Saputra commented on GORA-56:
-----------------------------------
Lewis, have you checked in the patch? Not sure if Chris has granted karma to the Gora repo yet.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Priority: Critical
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GORA-56) HBaseStore is not thread safe.
Posted by "Lewis John McGibbney (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GORA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lewis John McGibbney resolved GORA-56.
--------------------------------------
Resolution: Fixed
Fix Version/s: 0.2-incubating
Committed @ revision 1203184 in trunk.
Thanks to Ferdy and all reviewers for this one.
> HBaseStore is not thread safe.
> ------------------------------
>
> Key: GORA-56
> URL: https://issues.apache.org/jira/browse/GORA-56
> Project: Gora
> Issue Type: Bug
> Components: storage-hbase
> Reporter: Ferdy Galema
> Assignee: Lewis John McGibbney
> Priority: Critical
> Fix For: 0.2-incubating
>
> Attachments: GORA-56-v2.patch, GORA-56-v3.patch, GORA-56.patch
>
>
> Will be working on a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira