You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by kwmonroe <gi...@git.apache.org> on 2016/10/17 18:39:41 UTC
[GitHub] bigtop pull request #151: BIGTOP-2553: add rpc/http/https ports to template ...
GitHub user kwmonroe opened a pull request:
https://github.com/apache/bigtop/pull/151
BIGTOP-2553: add rpc/http/https ports to template for non-HA mode
Honor the `[namenode|http|https]_port` settings in non-HA mode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juju-solutions/bigtop bug/BIGTOP-2553/non-HA-ports
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #151
----
commit 6f05bee3deecd8ce8603230d1a16da1e5456a049
Author: Kevin W Monroe <ke...@canonical.com>
Date: 2016-10-17T17:38:08Z
add rpc/http/https ports to template for non-HA mode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/151
Pushed upstream with:
https://github.com/apache/bigtop/commit/cd55c144955e36188640c199b3100fefb3b28612
I forgot to add a "closes #151" to the commit, so i'm closing this out the old fashioned way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/151
I think you're saying the `namenode_hosts[host, index]` loop is the only difference, but that's a pretty big difference. The hdfs-site.xml property keys are not the same in HA and non-HA cases.
For example, property key in HA:
`dfs.namenode.rpc-address.<%= @nameservice_id %>.nn<%= idx+1 %>`
Same property key for non-HA:
`dfs.namenode.rpc-address`
By the time we check for a single item list and have an `if/else` block rendering different properties based on that list size, I think we're no better than we are now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...
Posted by johnsca <gi...@git.apache.org>.
Github user johnsca commented on the issue:
https://github.com/apache/bigtop/pull/151
Would the `namenode_hosts` contain more than one item in non-HA? Perhaps it would be cleaner to just move the loop out of the conditional and rely on it only running once in the non-HA case.
Also, why are HA and Kerberos mutually exclusive? The change preserves the existing logic, but the logic seems odd to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/151
@johnsca, `namenode_hosts` has only 1 item in non-HA mode. Note that once we hit the `else` to enter the "non HA" condition, we're not in any loop -- `namenode_hosts[0]` is how the one and only namenode was being referenced in other parts of the template, so I kept it the same:
https://github.com/apache/bigtop/blob/master/bigtop-deploy/puppet/modules/hadoop/templates/hdfs-site.xml#L98
Fwiw, I could use `@hadoop_namenode_host` if you think that would be cleaner.
As for HA/Kerberos, I do not know why they are mutually exclusive; as you noted, I preserved the original logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #151: BIGTOP-2553: add rpc/http/https ports to template ...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe closed the pull request at:
https://github.com/apache/bigtop/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...
Posted by johnsca <gi...@git.apache.org>.
Github user johnsca commented on the issue:
https://github.com/apache/bigtop/pull/151
@kwmonroe My point was that, since `namenode_hosts` only contains one item in the non-HA case, and the only difference in the code between the HA case and non-HA case was whether we looped over the code, it could be factored out into a single loop outside of the HA / non-HA check and it would do the right thing by dint of there being only a single item in the list.
It would save some code repetition, and avoid needing to change the `elif` condition, though the other part of my comment is that that seems strange to me in the first place (but, since it's outside the scope of this change, anyway, avoiding changing it at all seems better).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #151: BIGTOP-2553: add rpc/http/https ports to template for non...
Posted by johnsca <gi...@git.apache.org>.
Github user johnsca commented on the issue:
https://github.com/apache/bigtop/pull/151
Oh, of course you're correct. My mistake.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---