You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/16 03:47:52 UTC

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

1996fanrui commented on code in PR #21447:
URL: https://github.com/apache/flink/pull/21447#discussion_r1050345039


##########
flink-runtime/src/main/java/org/apache/flink/runtime/messages/ThreadInfoSample.java:
##########
@@ -32,25 +36,33 @@
  */
 public class ThreadInfoSample implements Serializable {
 
+    private final ExecutionAttemptID executionId;

Review Comment:
   Do you have any suggestions about it? When a TM has multiple slots, tm will return the thread result of all subtasks only once, JM needs to distinguish them, which subtask each ThreadInfoSample belongs to.
   
   How about using `<GenenicType> id` here? it can be any type, and not only serves for a flink execution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org