You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/10/16 21:57:42 UTC
[GitHub] beam pull request #4001: [BEAM-3052] Set end-of-window timer in AfterWaterma...
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/4001
[BEAM-3052] Set end-of-window timer in AfterWatermarkStateMachine
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
The state machines for the variants of `AfterWatermark.pastEndOfWindow()` were inconsistent in when they set a timer or not. Since this state machine should be decoupled from whatever context it is being run in, it should set a timer for the time it is interested in.
This is deliberately peeled off #3988 since it is simpler and more definitely correct. The other bits in that PR are under further revision.
R: @bjchambers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam AfterWatermark-timer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4001.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4001
----
commit db17a188ab98379e2985d01e63eaa2c4bb5893fd
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-10-12T20:38:27Z
Set end-of-window timer in AfterWatermarkStateMachine
----
---
[GitHub] beam pull request #4001: [BEAM-3052] Set end-of-window timer in AfterWaterma...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/4001
---