[GitHub] [incubator-seatunnel] lhyundeadsoul commented on a diff in pull request #2041: [api-draft][connector] Add simplified connector api

[GitBox <gi...@apache.org>]

lhyundeadsoul commented on code in PR #2041:
URL: https://github.com/apache/incubator-seatunnel/pull/2041#discussion_r912950907


##########
seatunnel-connectors/seatunnel-connectors-seatunnel/seatunnel-connector-seatunnel-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/source/SingleSplitReaderContext.java:
##########
@@ -15,23 +15,23 @@
  * limitations under the License.
  */
 
-package org.apache.seatunnel.connectors.seatunnel.fake.source;
+package org.apache.seatunnel.connectors.seatunnel.common.source;
 
-import org.apache.seatunnel.api.source.SourceSplit;
+import org.apache.seatunnel.api.source.Boundedness;
+import org.apache.seatunnel.api.source.SourceReader;
 
-public class FakeSourceSplit implements SourceSplit {
+public class SingleSplitReaderContext {

Review Comment:
   Why doesn't `org.apache.seatunnel.connectors.seatunnel.common.source.SingleSplitReaderContext` extend `SourceReader.Context` rather than composition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org