You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by zt...@apache.org on 2020/01/17 06:28:19 UTC
[submarine] 01/01: Exclude workbench-web-ng/dist and node_modules
in source distribution
This is an automated email from the ASF dual-hosted git repository.
ztang pushed a commit to annotated tag release-0.3.0-RC0
in repository https://gitbox.apache.org/repos/asf/submarine.git
commit 81ed46c6034acd878b60697fba2b1bb3ea00d4dd
Author: Zhankun Tang <zt...@apache.org>
AuthorDate: Fri Jan 17 10:58:38 2020 +0800
Exclude workbench-web-ng/dist and node_modules in source distribution
### What is this PR for?
When generating source tarball of submarine with below command, there's unneeded files zipped in the tarball. The workbench-web-ng/dist and workbench-web-ng/node_modules should be excluded from submarine-dist/src/assembly/src-distribution.xml.
mvn clean install package -DskipTests -Psrc
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-345
### How should this be tested?
mvn clean install package -DskipTests -Psrc
du -sm submarine-dist/target/submarine-dist-0.3.0-SNAPSHOT-src
The size of the dir should be about 30MB
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Zhankun Tang <zt...@apache.org>
Closes #152 from tangzhankun/submarine-345 and squashes the following commits:
8506a15 [Zhankun Tang] Exclude workbench-web-ng/dist and workbench-web-ng/node_modules in source assembly
(cherry picked from commit 4f0e696eccf6ab0319eec0c098de6e417b40465d)
---
submarine-dist/src/assembly/src-distribution.xml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/submarine-dist/src/assembly/src-distribution.xml b/submarine-dist/src/assembly/src-distribution.xml
index fcdb2bd..9266a5e 100644
--- a/submarine-dist/src/assembly/src-distribution.xml
+++ b/submarine-dist/src/assembly/src-distribution.xml
@@ -40,6 +40,8 @@
<exclude>submarine-workbench/workbench-web/dist/**</exclude>
<exclude>submarine-workbench/workbench-web/node_modules/**</exclude>
<exclude>submarine-workbench/workbench-web/node/**</exclude>
+ <exclude>submarine-workbench/workbench-web-ng/dist/**</exclude>
+ <exclude>submarine-workbench/workbench-web-ng/node_modules/**</exclude>
<!-- until the code that does this is fixed -->
<exclude>**/*.log</exclude>
<exclude>**/build/**</exclude>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org