[GitHub] [ozone] adoroszlai commented on a diff in pull request #3370: HDDS-6675. Avoid repeating some S3 tests for different bucket types

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3370:
URL: https://github.com/apache/ozone/pull/3370#discussion_r865753342


##########
hadoop-ozone/dist/src/main/compose/ozonesecure/test.sh:
##########
@@ -43,8 +43,11 @@ for scheme in ofs o3fs; do
   done
 done
 
+exclude=""
 for bucket in encrypted link generated; do
-  execute_robot_test s3g -v BUCKET:${bucket} -N s3-${bucket} s3
+  execute_robot_test s3g -v BUCKET:${bucket} -N s3-${bucket} ${exclude} s3
+  # some tests are independent of the bucket type, only need to be run once
+  exclude="--exclude no-bucket-type"

Review Comment:
   Exactly.  I learned this from @smengcl in #3174.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org