You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/01/16 09:30:21 UTC

[PR] HDDS-12093. Exclude generated code for import restrictions [ozone]

adoroszlai opened a new pull request, #7709:
URL: https://github.com/apache/ozone/pull/7709

   ## What changes were proposed in this pull request?
   
   Stop spending time analyzing generated code when validating import restrictions.  Saves around 6 seconds, which is not much for a normal build, but about 10% for local build when skipping tests.
   
   https://issues.apache.org/jira/browse/HDDS-12093
   
   ## How was this patch tested?
   
   ```bash
   mvn -DskipShade -DskipTests -Dskip.installnodenpm -Dskip.npx
   ```
   
   Before:
   
   ```
   [INFO] Apache Ozone HDDS Client Interface ................. SUCCESS [  5.458 s]
   [INFO] Apache Ozone HDDS Admin Interface .................. SUCCESS [  1.606 s]
   [INFO] Apache Ozone HDDS Server Interface ................. SUCCESS [  2.077 s]
   [INFO] Apache Ozone Client Interface ...................... SUCCESS [ 11.998 s]
   [INFO] Apache Ozone Storage Interface ..................... SUCCESS [  0.367 s]
   ```
   
   After:
   
   ```
   [INFO] Apache Ozone HDDS Client Interface ................. SUCCESS [  3.858 s]
   [INFO] Apache Ozone HDDS Admin Interface .................. SUCCESS [  1.109 s]
   [INFO] Apache Ozone HDDS Server Interface ................. SUCCESS [  1.481 s]
   [INFO] Apache Ozone Client Interface ...................... SUCCESS [  7.201 s]
   [INFO] Apache Ozone Storage Interface ..................... SUCCESS [  0.421 s]
   ```
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/12805099339
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12093. Exclude generated code when verifying import restrictions [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7709:
URL: https://github.com/apache/ozone/pull/7709#issuecomment-2601512090

   Thanks a lot @nandakumar131 for reviewing and merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12093. Exclude generated code when verifying import restrictions [ozone]

Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #7709:
URL: https://github.com/apache/ozone/pull/7709#issuecomment-2601300972

   Thanks @adoroszlai for the contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12093. Exclude generated code when verifying import restrictions [ozone]

Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #7709:
URL: https://github.com/apache/ozone/pull/7709#issuecomment-2601278875

   @adoroszlai, a big +1 for all these improvements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12093. Exclude generated code when verifying import restrictions [ozone]

Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 merged PR #7709:
URL: https://github.com/apache/ozone/pull/7709


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org