You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2018/10/24 12:29:30 UTC
[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11764
Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL
......................................................................
IMPALA-5031: Increase backend test timeout under UBSAN_FULL
When codegen is run with ubsan, backend tests slow down
dramatically. This patch increases the timeout to four hours in when
UBSAN_FULL is the build type. This limit is approached by expr-test,
which takes almost three hours under UBSAN_FULL.
Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
---
M be/CMakeLists.txt
M be/src/common/init.cc
2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/11764/1
--
To view, visit http://gerrit.cloudera.org:8080/11764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
Gerrit-Change-Number: 11764
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 )
Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3347/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
Gerrit-Change-Number: 11764
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Oct 2018 16:27:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 )
Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL
......................................................................
Patch Set 2: Code-Review+2
carry Tim's +2
--
To view, visit http://gerrit.cloudera.org:8080/11764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
Gerrit-Change-Number: 11764
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Oct 2018 16:27:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 )
Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
Gerrit-Change-Number: 11764
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Oct 2018 16:11:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 )
Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
Gerrit-Change-Number: 11764
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Oct 2018 20:27:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 )
Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1143/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
Gerrit-Change-Number: 11764
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Oct 2018 13:03:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11764 )
Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL
......................................................................
IMPALA-5031: Increase backend test timeout under UBSAN_FULL
When codegen is run with ubsan, backend tests slow down
dramatically. This patch increases the timeout to four hours in when
UBSAN_FULL is the build type. This limit is approached by expr-test,
which takes almost three hours under UBSAN_FULL.
Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
Reviewed-on: http://gerrit.cloudera.org:8080/11764
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/CMakeLists.txt
M be/src/common/init.cc
2 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eee4c2b3affc9d65d86c043fcc382d7248adf3e
Gerrit-Change-Number: 11764
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>