You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/25 06:58:36 UTC
[GitHub] [apisix-ingress-controller] neverCase opened a new pull request #772: feat: implement pluginconfig clients (#638)
neverCase opened a new pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
#638
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
___
### Backport patches
- Why need to backport?
- Source branch
- Related commits and pull requests
- Target branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (314d819) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b127ff4) will **decrease** coverage by `0.09%`.
> The diff coverage is `42.12%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 32.50% 32.40% -0.10%
==========================================
Files 66 66
Lines 6800 6993 +193
==========================================
+ Hits 2210 2266 +56
- Misses 4340 4452 +112
- Partials 250 275 +25
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | |
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
| [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <37.33%> (ø)` | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.18% <100.00%> (-3.15%)` | :arrow_down: |
| [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b127ff4...314d819](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978892163
@tao12345666333
hi, i'm ok.
I had add the missing license header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (904e1ba) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c6de2deb92c72b8d609490283c930a068df7d23?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c6de2d) will **increase** coverage by `0.20%`.
> The diff coverage is `42.12%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 32.07% 32.28% +0.20%
==========================================
Files 65 66 +1
Lines 6943 7137 +194
==========================================
+ Hits 2227 2304 +77
- Misses 4466 4565 +99
- Partials 250 268 +18
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | |
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
| [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <37.33%> (ø)` | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `33.49% <100.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0c6de2d...904e1ba](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-983543907
@tao12345666333
hi, i'm ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cf4bbdd) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f4708675c6304ad019881ad7e0ac7a0affd3e6bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f470867) will **increase** coverage by `0.20%`.
> The diff coverage is `42.12%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 32.28% 32.49% +0.20%
==========================================
Files 66 67 +1
Lines 6808 7002 +194
==========================================
+ Hits 2198 2275 +77
- Misses 4353 4452 +99
- Partials 257 275 +18
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | |
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
| [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <37.33%> (ø)` | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.18% <100.00%> (+0.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f470867...cf4bbdd](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#discussion_r759988121
##########
File path: pkg/apisix/cache/cache.go
##########
@@ -82,4 +88,6 @@ type Cache interface {
DeleteConsumer(*v1.Consumer) error
// DeleteSchema deletes the specified schema in cache.
DeleteSchema(*v1.Schema) error
+ // DeletePluginConfig deletes the specified plugin_config in cache.
+ DeletePluginConfig(config *v1.PluginConfig) error
Review comment:
```suggestion
DeletePluginConfig(*v1.PluginConfig) error
```
##########
File path: pkg/apisix/cache/memdb_test.go
##########
@@ -389,3 +389,58 @@ func TestMemDBCacheSchema(t *testing.T) {
}
assert.Error(t, ErrNotFound, c.DeleteSchema(s4))
}
+
+func TestMemDBCachePluginConfig(t *testing.T) {
+ c, err := NewMemDBCache()
+ assert.Nil(t, err, "NewMemDBCache")
+
+ pc1 := &v1.PluginConfig{
+ Metadata: v1.Metadata{
+ ID: "1",
+ Name: "name1",
+ },
+ }
+ assert.Nil(t, c.InsertPluginConfig(pc1), "inserting plugin_config s1")
+
+ pc11, err := c.GetPluginConfig("1")
+ assert.Nil(t, err)
+ assert.Equal(t, pc1, pc11)
+
+ pc2 := &v1.PluginConfig{
+ Metadata: v1.Metadata{
+ ID: "2",
+ Name: "name2",
+ },
+ }
+ s3 := &v1.PluginConfig{
+ Metadata: v1.Metadata{
+ ID: "3",
+ Name: "name3",
+ },
+ }
+ assert.Nil(t, c.InsertPluginConfig(pc2), "inserting plugin_config s2")
Review comment:
And no s2
##########
File path: pkg/apisix/cache/memdb_test.go
##########
@@ -389,3 +389,58 @@ func TestMemDBCacheSchema(t *testing.T) {
}
assert.Error(t, ErrNotFound, c.DeleteSchema(s4))
}
+
+func TestMemDBCachePluginConfig(t *testing.T) {
+ c, err := NewMemDBCache()
+ assert.Nil(t, err, "NewMemDBCache")
+
+ pc1 := &v1.PluginConfig{
+ Metadata: v1.Metadata{
+ ID: "1",
+ Name: "name1",
+ },
+ }
+ assert.Nil(t, c.InsertPluginConfig(pc1), "inserting plugin_config s1")
Review comment:
There is no s1.
##########
File path: pkg/apisix/cache/memdb_test.go
##########
@@ -354,7 +354,7 @@ func TestMemDBCacheSchema(t *testing.T) {
Name: "plugins/p1",
Content: "plugin schema",
}
- assert.Nil(t, c.InsertSchema(s1), "inserting schema s1")
+ assert.Nil(t, c.InsertSchema(s1), "inserting schema pc1")
Review comment:
Why amend it here?
##########
File path: pkg/apisix/pluginconfig.go
##########
@@ -0,0 +1,235 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package apisix
+
+import (
+ "bytes"
+ "context"
+ "encoding/json"
+
+ "go.uber.org/zap"
+
+ "github.com/apache/apisix-ingress-controller/pkg/apisix/cache"
+ "github.com/apache/apisix-ingress-controller/pkg/id"
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+ v1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+type pluginConfigClient struct {
+ url string
+ cluster *cluster
+}
+
+func newPluginConfigClient(c *cluster) PluginConfig {
+ return &pluginConfigClient{
+ url: c.baseURL + "/plugin_configs",
+ cluster: c,
+ }
+}
+
+// Get returns the v1.PluginConfig.
+// FIXME, currently if caller pass a non-existent resource, the Get always passes
+// through cache.
+func (pc *pluginConfigClient) Get(ctx context.Context, name string) (*v1.PluginConfig, error) {
+ log.Debugw("try to look up pluginConfig",
+ zap.String("name", name),
+ zap.String("url", pc.url),
+ zap.String("cluster", "default"),
+ )
+ rid := id.GenID(name)
+ pluginConfig, err := pc.cluster.cache.GetPluginConfig(rid)
+ if err == nil {
+ return pluginConfig, nil
+ }
+ if err != cache.ErrNotFound {
+ log.Errorw("failed to find pluginConfig in cache, will try to lookup from APISIX",
+ zap.String("name", name),
+ zap.Error(err),
+ )
+ } else {
+ log.Debugw("pluginConfig not found in cache, will try to lookup from APISIX",
+ zap.String("name", name),
+ zap.Error(err),
+ )
+ }
+
+ // TODO Add mutex here to avoid dog-pile effect.
+ url := pc.url + "/" + rid
+ resp, err := pc.cluster.getResource(ctx, url, "pluginConfig")
+ pc.cluster.metricsCollector.IncrAPISIXRequest("pluginConfig")
+ if err != nil {
+ if err == cache.ErrNotFound {
+ log.Warnw("pluginConfig not found",
+ zap.String("name", name),
+ zap.String("url", url),
+ zap.String("cluster", "default"),
+ )
+ } else {
+ log.Errorw("failed to get pluginConfig from APISIX",
+ zap.String("name", name),
+ zap.String("url", url),
+ zap.String("cluster", "default"),
+ zap.Error(err),
+ )
+ }
+ return nil, err
+ }
+
+ pluginConfig, err = resp.Item.pluginConfig()
+ if err != nil {
+ log.Errorw("failed to convert pluginConfig item",
+ zap.String("url", pc.url),
+ zap.String("pluginConfig_key", resp.Item.Key),
+ zap.String("pluginConfig_value", string(resp.Item.Value)),
+ zap.Error(err),
+ )
+ return nil, err
+ }
+
+ if err := pc.cluster.cache.InsertPluginConfig(pluginConfig); err != nil {
+ log.Errorf("failed to reflect pluginConfig create to cache: %s", err)
+ return nil, err
+ }
+ return pluginConfig, nil
+}
+
+// List is only used in cache warming up. So here just pass through
+// to APISIX.
+func (pc *pluginConfigClient) List(ctx context.Context) ([]*v1.PluginConfig, error) {
+ log.Debugw("try to list pluginConfig in APISIX",
+ zap.String("cluster", "default"),
+ zap.String("url", pc.url),
+ )
+ pluginConfigItems, err := pc.cluster.listResource(ctx, pc.url, "pluginConfig")
+ pc.cluster.metricsCollector.IncrAPISIXRequest("pluginConfig")
+ if err != nil {
+ log.Errorf("failed to list pluginConfig: %s", err)
+ return nil, err
+ }
+
+ var items []*v1.PluginConfig
+ for i, item := range pluginConfigItems.Node.Items {
+ pluginConfig, err := item.pluginConfig()
+ if err != nil {
+ log.Errorw("failed to convert pluginConfig item",
+ zap.String("url", pc.url),
+ zap.String("pluginConfig_key", item.Key),
+ zap.String("pluginConfig_value", string(item.Value)),
+ zap.Error(err),
+ )
+ return nil, err
+ }
+
+ items = append(items, pluginConfig)
+ log.Debugf("list pluginConfig #%d, body: %s", i, string(item.Value))
+ }
+
+ return items, nil
+}
+
+func (pc *pluginConfigClient) Create(ctx context.Context, obj *v1.PluginConfig) (*v1.PluginConfig, error) {
+ log.Debugw("try to create pluginConfig",
+ zap.String("name", obj.Name),
+ zap.Any("plugins", obj.Plugins),
+ zap.String("cluster", "default"),
+ zap.String("url", pc.url),
+ )
+
+ if err := pc.cluster.HasSynced(ctx); err != nil {
+ return nil, err
+ }
+ data, err := json.Marshal(obj)
+ if err != nil {
+ return nil, err
+ }
+
+ url := pc.url + "/" + obj.ID
+ log.Debugw("creating pluginConfig", zap.ByteString("body", data), zap.String("url", url))
+ resp, err := pc.cluster.createResource(ctx, url, "pluginConfig", bytes.NewReader(data))
+ pc.cluster.metricsCollector.IncrAPISIXRequest("pluginConfig")
+ if err != nil {
+ log.Errorf("failed to create pluginConfig: %s", err)
+ return nil, err
+ }
+
+ pluginConfig, err := resp.Item.pluginConfig()
+ if err != nil {
+ return nil, err
+ }
+ if err := pc.cluster.cache.InsertPluginConfig(pluginConfig); err != nil {
+ log.Errorf("failed to reflect pluginConfig create to cache: %s", err)
+ return nil, err
+ }
+ return pluginConfig, nil
+}
+
+func (pc *pluginConfigClient) Delete(ctx context.Context, obj *v1.PluginConfig) error {
+ log.Debugw("try to delete pluginConfig",
+ zap.String("id", obj.ID),
+ zap.String("name", obj.Name),
+ zap.String("cluster", "default"),
+ zap.String("url", pc.url),
+ )
+ if err := pc.cluster.HasSynced(ctx); err != nil {
+ return err
+ }
+ url := pc.url + "/" + obj.ID
+ if err := pc.cluster.deleteResource(ctx, url, "pluginConfig"); err != nil {
+ pc.cluster.metricsCollector.IncrAPISIXRequest("pluginConfig")
+ return err
+ }
+ pc.cluster.metricsCollector.IncrAPISIXRequest("pluginConfig")
+ if err := pc.cluster.cache.DeletePluginConfig(obj); err != nil {
+ log.Errorf("failed to reflect pluginConfig delete to cache: %s", err)
+ if err != cache.ErrNotFound {
+ return err
+ }
+ }
+ return nil
+}
+
+func (pc *pluginConfigClient) Update(ctx context.Context, obj *v1.PluginConfig) (*v1.PluginConfig, error) {
+ log.Debugw("try to update pluginConfig",
+ zap.String("id", obj.ID),
+ zap.String("name", obj.Name),
+ zap.Any("plugins", obj.Plugins),
+ zap.String("cluster", "default"),
+ zap.String("url", pc.url),
+ )
+ if err := pc.cluster.HasSynced(ctx); err != nil {
+ return nil, err
+ }
+ body, err := json.Marshal(obj)
+ if err != nil {
+ return nil, err
+ }
+ url := pc.url + "/" + obj.ID
+ log.Debugw("updating username", zap.ByteString("body", body), zap.String("url", url))
Review comment:
typo. no "username"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-983469190
> @neverCase Sorry for delay. I leave some comments, I hope you can make changes
ok, i will change these and update right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cf4bbdd) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f4708675c6304ad019881ad7e0ac7a0affd3e6bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f470867) will **increase** coverage by `0.19%`.
> The diff coverage is `42.12%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 32.28% 32.48% +0.19%
==========================================
Files 66 66
Lines 6808 7001 +193
==========================================
+ Hits 2198 2274 +76
- Misses 4353 4452 +99
- Partials 257 275 +18
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | |
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
| [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <37.33%> (ø)` | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.18% <100.00%> (+0.16%)` | :arrow_up: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f470867...cf4bbdd](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on a change in pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
neverCase commented on a change in pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#discussion_r756740654
##########
File path: pkg/apisix/plugin_test.go
##########
@@ -23,6 +23,7 @@ import (
"testing"
"github.com/apache/apisix-ingress-controller/pkg/metrics"
+
Review comment:
My local golangci-lint would print these warnings below:
```sh
golangci-lint run
pkg/apisix/plugin_test.go:25: File is not `goimports`-ed with -local github.com/apache/apisix-ingress-controller (goimports)
"github.com/apache/apisix-ingress-controller/pkg/metrics"
pkg/apisix/schema_test.go:24: File is not `goimports`-ed with -local github.com/apache/apisix-ingress-controller (goimports)
"github.com/apache/apisix-ingress-controller/pkg/metrics"
```
Finally, I found that if I split the imports then there no warnings left.
Maybe I should ignore it in the next commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (314d819) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b127ff4) will **decrease** coverage by `0.08%`.
> The diff coverage is `42.12%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 32.50% 32.41% -0.09%
==========================================
Files 66 67 +1
Lines 6800 6994 +194
==========================================
+ Hits 2210 2267 +57
- Misses 4340 4452 +112
- Partials 250 275 +25
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | |
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
| [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <37.33%> (ø)` | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.18% <100.00%> (-3.15%)` | :arrow_down: |
| [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b127ff4...314d819](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-983577973
ping @gxthrj @tokers for review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-988576890
#788 has fixed the e2e error. It's green!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#discussion_r756731092
##########
File path: pkg/apisix/plugin_test.go
##########
@@ -23,6 +23,7 @@ import (
"testing"
"github.com/apache/apisix-ingress-controller/pkg/metrics"
+
Review comment:
Can we sort these imports?
##########
File path: pkg/apisix/pluginconfig_test.go
##########
@@ -0,0 +1,220 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package apisix
+
+import (
+ "context"
+ "encoding/json"
+ "fmt"
+ "io/ioutil"
+ "net/http"
+ "net/url"
+ "sort"
+ "strconv"
+ "strings"
+ "testing"
+
+ "github.com/apache/apisix-ingress-controller/pkg/metrics"
+ v1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
Review comment:
Ditto, we should sort these imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-983448305
@neverCase Sorry for delay. I leave some comments, I hope you can make changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
neverCase commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-984455512
> > Mostly LGTM but some import block style problems.
>
> @neverCase can you improve the code style?
I had revert it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0662b5f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b127ff4) will **increase** coverage by `0.18%`.
> The diff coverage is `42.12%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 32.50% 32.68% +0.18%
==========================================
Files 66 66
Lines 6800 6993 +193
==========================================
+ Hits 2210 2286 +76
- Misses 4340 4439 +99
- Partials 250 268 +18
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | |
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: |
| [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <37.33%> (ø)` | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `38.81% <42.50%> (-2.98%)` | :arrow_down: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `60.27% <66.66%> (+0.57%)` | :arrow_up: |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `75.12% <76.47%> (+0.12%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `33.49% <100.00%> (+0.15%)` | :arrow_up: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b127ff4...0662b5f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-984438621
> Mostly LGTM but some import block style problems.
@neverCase can you improve the code style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#discussion_r757186979
##########
File path: pkg/apisix/plugin_test.go
##########
@@ -23,6 +23,7 @@ import (
"testing"
"github.com/apache/apisix-ingress-controller/pkg/metrics"
+
Review comment:
I think it's caused by the lexicographical orders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-988586877
Good job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #772: feat: implement pluginconfig clients (#638)
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #772:
URL: https://github.com/apache/apisix-ingress-controller/pull/772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org