[jira] [Commented] (RATIS-155) TestSegmentedRaftLog and TestCacheEviction may fail due to NullPointerException

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264849#comment-16264849 ] 

Tsz Wo Nicholas Sze commented on RATIS-155:
-------------------------------------------

It seems a simple fix is to check if raftServer is null below.  For mock server, just mock also the id.
{code}
// RaftLogWorker constructor
    this.logFlushTimer = JavaUtils.memoize(() -> RatisMetricsRegistry.getRegistry()
        .timer(MetricRegistry.name(RaftLogWorker.class, raftServer.getId().toString(),
            "flush-time")));
{code}


> TestSegmentedRaftLog and TestCacheEviction may fail due to NullPointerException 
> --------------------------------------------------------------------------------
>
>                 Key: RATIS-155
>                 URL: https://issues.apache.org/jira/browse/RATIS-155
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: Tsz Wo Nicholas Sze
>
> {code}
> 2017-11-23 16:30:44, 212 ERROR storage.RaftLogWorker (ExitUtils.java:terminate(86)) - Terminating with exit status 1: s0-RaftLogWorker failed.
> java.lang.NullPointerException
> 	at org.apache.ratis.server.storage.RaftLogWorker.lambda$new$0(RaftLogWorker.java:98)
> 	at org.apache.ratis.util.JavaUtils$1.get(JavaUtils.java:90)
> 	at org.apache.ratis.server.storage.RaftLogWorker.flushWrites(RaftLogWorker.java:219)
> 	at org.apache.ratis.server.storage.RaftLogWorker.access$500(RaftLogWorker.java:47)
> 	at org.apache.ratis.server.storage.RaftLogWorker$WriteLog.execute(RaftLogWorker.java:302)
> 	at org.apache.ratis.server.storage.RaftLogWorker.run(RaftLogWorker.java:174)
> 	at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)