You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Tuomas Kiviaho (Jira)" <ji...@apache.org> on 2021/09/22 15:11:00 UTC

[jira] [Created] (FELIX-6460) {maven-test-sources} not working as expected

Tuomas Kiviaho created FELIX-6460:
-------------------------------------

             Summary: {maven-test-sources} not working as expected
                 Key: FELIX-6460
                 URL: https://issues.apache.org/jira/browse/FELIX-6460
             Project: Felix
          Issue Type: Bug
          Components: Maven Bundle Plugin
    Affects Versions: maven-bundle-plugin-5.1.2, maven-bundle-plugin-2.5.0
            Reporter: Tuomas Kiviaho


I seem to have introduced a bug along my patch for FELIX-3381. 

There is should be a test in BundlePlugin.java whether \{maven-sources} and/or \{maven-test-sources} placeholders are present but instead I've managed to typo \{maven-test-resources} there instead.

Could this simple typo be fixed
{code:java|title=BundlePlugin.java}
@@ -2143,7 +2143,7 @@
         final String sourcePath = analyzer.getProperty( Analyzer.SOURCEPATH );
         if ( sourcePath != null )
         {
-            if ( sourcePath.contains(MAVEN_SOURCES) || sourcePath.contains(MAVEN_TEST_RESOURCES) )
+            if ( sourcePath.contains(MAVEN_SOURCES) || sourcePath.contains(MAVEN_TEST_SOURCES) )
             {
                 String combinedSource = StringUtils.replace( sourcePath, MAVEN_SOURCES, mavenSourcePaths.toString() );
                 combinedSource = StringUtils.replace( combinedSource, MAVEN_TEST_SOURCES, mavenTestSourcePaths.toString() );
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)