You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jasonxh <gi...@git.apache.org> on 2016/06/21 19:41:39 UTC
[GitHub] zeppelin pull request #1059: Fix table cell selection problem on second run ...
GitHub user jasonxh opened a pull request:
https://github.com/apache/zeppelin/pull/1059
Fix table cell selection problem on second run by properly destroying hot.
### What is this PR for?
* Fix table cell selection problem on second run by properly destroying hot.
* Also make cells readonly. Previously one were able to paste into them.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
* [ZEPPELIN-954]
### How should this be tested?
Execute the following paragraph multiple times, and verify the table cells are still selectable.
```
%sh
echo %table
echo -e "col1\tcol2\tcol3"
echo -e "1\t2.1\tabcdefg"
```
Also try to paste anything into a cell to no avail.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/optimizely/incubator-zeppelin hao/hot-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1059.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1059
----
commit 5bd95029be74615e008e6dc0eb19cf5c0d6246f3
Author: Hao Xia <ha...@optimizely.com>
Date: 2016-06-21T19:18:45Z
Fix selection problem on second run by properly destroying hot.
Also make cells readonly. Previously one were able to paste into them.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1059: [ZEPPELIN-954] Fix table cell selection problem on sec...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1059
Tested, No more handsontable duplicates.
Was there no other way to just update the data instead of destroying the table and creating a new one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1059: [ZEPPELIN-954] Fix table cell selection problem on sec...
Posted by jasonxh <gi...@git.apache.org>.
Github user jasonxh commented on the issue:
https://github.com/apache/zeppelin/pull/1059
@corneadoug good suggestion. i updated the pr to reuse the table when possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1059: [ZEPPELIN-954] Fix table cell selection problem on sec...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1059
Merge it there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1059: [ZEPPELIN-954] Fix table cell selection problem on sec...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1059
\cc @corneadoug for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1059: [ZEPPELIN-954] Fix table cell selection problem...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1059
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1059: [ZEPPELIN-954] Fix table cell selection problem on sec...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1059
Tested both cases, looks good to me \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---