You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2026/05/19 01:33:36 UTC
[PR] Docs: add more to 1.10.2 release notes [iceberg]
kevinjqliu opened a new pull request, #16410:
URL: https://github.com/apache/iceberg/pull/16410
Context: https://github.com/apache/iceberg/pull/16406#issuecomment-4483365436
Include Open API jar changes to the 1.10.2 release notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263561788
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
I think release notes is the most effective channel to communicate the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263286409
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
im not sure i understand; i thought the side effect is that we stop publishing the open api runtime jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263761086
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
added some context, verified by running the rest service locally
```
- Stop publishing the Open API runtime Jar due to license compliance issues ([\#16188](https://github.com/apache/iceberg/pull/16188)). Users who depended on the shadow JAR must now use the `test-fixtures` classifier and explicitly add `iceberg-core`, `iceberg-core:tests`, `jetty-server`, `jetty-servlet`, `sqlite-jdbc`, and `hadoop-common`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263299461
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
It changes the downstream dependencies if a project has previously depended on `iceberg-open-api` as I've shown in https://github.com/manuzhang/iceberg-examples/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263348089
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
> i do see that the iceberg-open-api jar is no longer in 1.10.2
Yes, that's why `org.apache.iceberg:iceberg-core:jar:tests:1.10.2` and other dependencies might be required now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263221688
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
Do we need to mention what's side effect of this change?
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
Do we need to mention what's the side effect of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263333724
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
could you try again with the released 1.10.2?
i think maybe the RC version had the iceberg-open-api jar perhaps, i cant verify because https://repository.apache.org/content/repositories/orgapacheiceberg-1281/ is gone
i do see that the iceberg-open-api jar is no longer in 1.10.2 https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-open-api/1.10.2/ (but is in 1.10.1 https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-open-api/1.10.1/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#issuecomment-4483684708
cc @manuzhang thanks for pointing this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263623593
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
Even if we are going to fix it in 1.11.x, I believe it's worth calling out in the 1.11.0 release notes as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263158209
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
Review Comment:
```suggestion
- Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162))
```
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
made this more explicit instead of the PR title (`Open API: Backport 1.10 Remove runtime Jar from build and deploy`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263561788
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
I think release notes is the best effect channel to communicate the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263757001
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162))
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
```suggestion
- Stop publishing the Open API runtime Jar due to license compliance issues ([\#16188](https://github.com/apache/iceberg/pull/16188)). Users who depended on the shadow JAR must now use the `test-fixtures` classifier and explicitly add `iceberg-core`, `iceberg-core:tests`, `jetty-server`, `jetty-servlet`, `sqlite-jdbc`, and `hadoop-common`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263574754
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
oh i see. i was under the assumption that we will fix forward the open-api jar. but i think we're only doing that for the 1.11.x release.
so for 1.10.2 here, i think its worth explaining the change 👍 thanks!
LMK if you have any suggestions for wording here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #16410:
URL: https://github.com/apache/iceberg/pull/16410#discussion_r3263553697
##########
site/docs/releases.md:
##########
@@ -82,17 +82,19 @@ The 1.10.2 release contains bug fixes and security fixes. For full release notes
- Fix row ID assignment for EXISTING entries during manifest merge ([\#16304](https://github.com/apache/iceberg/pull/16304))
* Flink
- Fix non-deterministic operator UIDs in DynamicIcebergSink ([\#15738](https://github.com/apache/iceberg/pull/15738))
- - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175))
+ - Fix LICENSE and NOTICE files ([\#16175](https://github.com/apache/iceberg/pull/16175), [\#16130](https://github.com/apache/iceberg/pull/16130))
* Hive
- Fix trailing slash issue for database paths in HMS ([\#16010](https://github.com/apache/iceberg/pull/16010))
* Spark
- - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255))
+ - Fix LICENSE and NOTICE files ([\#16255](https://github.com/apache/iceberg/pull/16255), [\#16162](https://github.com/apache/iceberg/pull/16162), )
* AWS
- Fix LICENSE and NOTICE files ([\#16236](https://github.com/apache/iceberg/pull/16236))
* Azure
- - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242))
+ - Fix LICENSE and NOTICE files ([\#16242](https://github.com/apache/iceberg/pull/16242), [\#16260](https://github.com/apache/iceberg/pull/16260))
* GCP
- Fix LICENSE and NOTICE files ([\#16244](https://github.com/apache/iceberg/pull/16244))
+* Open API
+ - Stop publishing the Open API runtime Jar ([\#16188](https://github.com/apache/iceberg/pull/16188))
Review Comment:
I'm okay either way here, on the one hand to me, I think this statement is enough but if it's helpful to include a note on what other dependencies need to be pulled in to achieve the same "things" that people would achieve when consuming the open API jar before then maybe we mention that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add more to 1.10.2 release notes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #16410:
URL: https://github.com/apache/iceberg/pull/16410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org