You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by Zhangshunyu <gi...@git.apache.org> on 2016/10/26 13:57:12 UTC

[GitHub] incubator-carbondata pull request #259: Fix constants and method names

GitHub user Zhangshunyu opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/259

    Fix constants and method names

    ## Why raise this pr?
    To rename some constants and method names, for example:
    It is hard to get clear about what the parameter is used for 'carbon.number.of.cores', cores for what?
    It is hard to get clear about what the method is used for 'getNumberOfCores', query or load cores?
    etc
    ## How to test?
    Pass all the test cases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Zhangshunyu/incubator-carbondata constants

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #259
    
----
commit 8a3c1b4758a93d7e5b7c1d983f9a9309995f4c79
Author: Zhangshunyu <zh...@huawei.com>
Date:   2016-10-26T13:53:21Z

    Fix constans

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #259: [WIP]Fix constants and method names

Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/259


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---