[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #1921: [KYUUBI #1920] Skip the Plan parsing of UseStatement

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #1921:
URL: https://github.com/apache/incubator-kyuubi/pull/1921#discussion_r809614550



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala
##########
@@ -38,23 +38,25 @@ class PlanOnlyStatement(
   private val operationLog: OperationLog = OperationLog.createOperationLog(session, getHandle)
   override def getOperationLog: Option[OperationLog] = Option(operationLog)
 
-  override protected def resultSchema: StructType =
-    if (result == null) {
+  override protected def resultSchema: StructType = Option(result) match {
+    case Some(res) if res.isEmpty =>
+      new StructType().add("Result", "string")
+    case Some(res) =>
+      res.schema
+    case _ =>
       new StructType().add("plan", "string")
-    } else {
-      result.schema
-    }
+  }
 
-  private def isSetOrReset(plan: LogicalPlan): Boolean = {
+  private def shouldDirectRun(plan: LogicalPlan): Boolean = {
     val className = plan.getClass.getSimpleName
-    className == "SetCommand" || className == "ResetCommand"
+    className == "SetCommand" || className == "ResetCommand" || className == "UseStatement"

Review comment:
       In Spark 3.0, `UseStatement` is replaced with `SetNamespaceCommand`, which changes in [https://github.com/apache/spark/pull/34127](https://github.com/apache/spark/pull/34127).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org