You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "afedulov (via GitHub)" <gi...@apache.org> on 2023/10/07 22:14:36 UTC
[PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArhitectureTests [flink]
afedulov opened a new pull request, #23491:
URL: https://github.com/apache/flink/pull/23491
## What is the purpose of the change
Currently architecture tests rely on importing such classes as `MiniClusterExtension`. This introduces a production scope dependency on `flink-test-utils` which in turn depends on `flink-streaming-java`. This is problematic because adding architecture tests to any direct or transitive dependency of `flink-streaming-java` creates a dependency cycle.
Example: https://github.com/apache/flink/pull/22850#discussion_r1243343382
In general, since architecture tests are supposed to be used freely in any submodule, it is desirable to reduce its dependency surface as much as possible to prevent such cycles.
## Brief change log
- Modifies methods to using fully qualified type names checks instead of Class objects
- Removes production maven dependencies on `flink-test-utils`, `flink-test-utils-junit` and `flink-connector-test-utils`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1356745320
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -62,40 +68,42 @@ public static DescribedPredicate<JavaClass> containAnyFieldsInClassHierarchyThat
}
/**
- * Tests that the given field is {@code public static} and of the given type {@code clazz} .
+ * Tests that the given field is {@code public static} and has the fully qualified type name of
+ * {@code fqClassName}.
*
* <p>Attention: changing the description will add a rule into the stored.rules.
*/
- public static DescribedPredicate<JavaField> arePublicStaticOfType(Class<?> clazz) {
Review Comment:
> What do think, could checking out all the connector repos in the main Flink CI run work for us?
I think we just to clarify what is part of the user (connector?) facing API, annotate them accordingly, and them treat them as other public APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1354883300
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -62,40 +68,42 @@ public static DescribedPredicate<JavaClass> containAnyFieldsInClassHierarchyThat
}
/**
- * Tests that the given field is {@code public static} and of the given type {@code clazz} .
+ * Tests that the given field is {@code public static} and has the fully qualified type name of
+ * {@code fqClassName}.
*
* <p>Attention: changing the description will add a rule into the stored.rules.
*/
- public static DescribedPredicate<JavaField> arePublicStaticOfType(Class<?> clazz) {
Review Comment:
Good point! I ran a script to search for the following methods
```
areFieldOfType
arePublicFinalOfType
arePublicStaticOfType
arePublicStaticFinalOfType
arePublicFinalOfTypeWithAnnotation
arePublicStaticFinalOfTypeWithAnnotation
areStaticFinalOfTypeWithAnnotation
```
across these repositories
```
apache/flink-connector-kafka
apache/flink-connector-cassandra
apache/flink-connector-elasticsearch
apache/flink-connector-rabbitmq
apache/flink-connector-google-cloud-pubsub
apache/flink-connector-pulsar
apache/flink-connector-jdbc
apache/flink-connector-hbase
apache/flink-connector-hive
apache/flink-connector-aws
apache/flink-connector-firehose
apache/flink-connector-kinesis
apache/flink-connector-dynamodb
```
and did not find any usage.
It seems that the question "Does this change in Flink break any connector?" will be a recurring topic with the externalized repos. Having some automated checks is tricky, but feasible:
1) get all the method signature changes in the PR
2) search across the connector repos for usage of the respective classes + methods
The experience I just made is that using GitHub API won't work due to pretty heavy throttling on their side. What do think, could checking out all the connector repos in the main Flink CI run work for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1354883300
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -62,40 +68,42 @@ public static DescribedPredicate<JavaClass> containAnyFieldsInClassHierarchyThat
}
/**
- * Tests that the given field is {@code public static} and of the given type {@code clazz} .
+ * Tests that the given field is {@code public static} and has the fully qualified type name of
+ * {@code fqClassName}.
*
* <p>Attention: changing the description will add a rule into the stored.rules.
*/
- public static DescribedPredicate<JavaField> arePublicStaticOfType(Class<?> clazz) {
Review Comment:
Good point! I ran a script to search for the following methods
```
areFieldOfType
arePublicFinalOfType
arePublicStaticOfType
arePublicStaticFinalOfType
arePublicFinalOfTypeWithAnnotation
arePublicStaticFinalOfTypeWithAnnotation
areStaticFinalOfTypeWithAnnotation
```
across these repositories
```
apache/flink-connector-kafka
apache/flink-connector-cassandra
apache/flink-connector-elasticsearch
apache/flink-connector-rabbitmq
apache/flink-connector-google-cloud-pubsub
apache/flink-connector-pulsar
apache/flink-connector-jdbc
apache/flink-connector-hbase
apache/flink-connector-hive
apache/flink-connector-aws
apache/flink-connector-firehose
apache/flink-connector-kinesis
apache/flink-connector-dynamodb
```
and did not find any usage.
It seems that the question "Does this change in Flink break any connector?" will be a recurring topic with the externalized repos. Having some automated checks is tricky, but feasible:
1) get all the method signature changes in the PR
2) search across the connector repos for usage of the respective classes + methods
The experience I just made is that using GitHub API won't work due to pretty heavy throttling on their side. What do, will checking out all the connector repos in the main Flink CI run work for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on PR #23491:
URL: https://github.com/apache/flink/pull/23491#issuecomment-1757592401
@zentol thanks, Chesnay! I addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArhitectureTests [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23491:
URL: https://github.com/apache/flink/pull/23491#issuecomment-1751843154
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ccd6ac5e2b5d3cb1b46fad260b183408d8e7d5d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccd6ac5e2b5d3cb1b46fad260b183408d8e7d5d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccd6ac5e2b5d3cb1b46fad260b183408d8e7d5d4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol merged PR #23491:
URL: https://github.com/apache/flink/pull/23491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1354883300
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -62,40 +68,42 @@ public static DescribedPredicate<JavaClass> containAnyFieldsInClassHierarchyThat
}
/**
- * Tests that the given field is {@code public static} and of the given type {@code clazz} .
+ * Tests that the given field is {@code public static} and has the fully qualified type name of
+ * {@code fqClassName}.
*
* <p>Attention: changing the description will add a rule into the stored.rules.
*/
- public static DescribedPredicate<JavaField> arePublicStaticOfType(Class<?> clazz) {
Review Comment:
Good point! I ran a script to search for the following methods
```
areFieldOfType
arePublicFinalOfType
arePublicStaticOfType
arePublicStaticFinalOfType
arePublicFinalOfTypeWithAnnotation
arePublicStaticFinalOfTypeWithAnnotation
areStaticFinalOfTypeWithAnnotation
```
across these repositories
```
apache/flink-connector-kafka
apache/flink-connector-cassandra
apache/flink-connector-elasticsearch
apache/flink-connector-rabbitmq
apache/flink-connector-google-cloud-pubsub
apache/flink-connector-pulsar
apache/flink-connector-jdbc
apache/flink-connector-hbase
apache/flink-connector-hive
apache/flink-connector-aws
apache/flink-connector-firehose
apache/flink-connector-kinesis
apache/flink-connector-dynamodb
```
and did not find any usage.
It seems that the question "Does this change in Flink break any connector?" will be a recurring topic with the externalized repos. Having some automated checks is tricky, but feasible:
1) get all the method signature changes in the PR
2) search across the connector repos for usage of the respective classes + methods
The experience I just made is that it won't work with GitHub API due to pretty heavy throttling on their side. What do, will checking out all the connector repos in the main Flink CI run work for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArhitectureTests [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1351993174
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -62,40 +68,42 @@ public static DescribedPredicate<JavaClass> containAnyFieldsInClassHierarchyThat
}
/**
- * Tests that the given field is {@code public static} and of the given type {@code clazz} .
+ * Tests that the given field is {@code public static} and has the fully qualified type name of
+ * {@code fqClassName}.
*
* <p>Attention: changing the description will add a rule into the stored.rules.
*/
- public static DescribedPredicate<JavaField> arePublicStaticOfType(Class<?> clazz) {
Review Comment:
Do we know whether any of these methods are also used by connector repos? Wondering about compile error when working against newer Flink versions.
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -157,6 +166,35 @@ public static <T> DescribedPredicate<T> exactlyOneOf(
t -> Arrays.stream(other).map(dp -> dp.test(t)).reduce(false, Boolean::logicalXor));
}
+ /**
+ * Extracts the class name from the given fully qualified class name.
+ *
+ * <p>Example:
+ *
+ * <pre>
+ * getClassFromFqName("com.example.MyClass"); // Returns: "MyClass"
+ * </pre>
+ */
+ public static String getClassSimpleNameFromFqName(String fqClassName) {
Review Comment:
One thing to be careful of is what kind of fqcn you are using.
Canonical names can for example contain a `$` before the simple name if you are dealing with an inner class. Or its the other way around that getName returns it; this always trips me up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1357991461
##########
flink-architecture-tests/flink-architecture-tests-base/src/test/java/PredicatesTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.jupiter.api.Test;
+
+import static org.apache.flink.architecture.common.Predicates.getClassSimpleNameFromFqName;
+import static org.assertj.core.api.Assertions.*;
Review Comment:
@bvarghese1 indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "bvarghese1 (via GitHub)" <gi...@apache.org>.
bvarghese1 commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1357730455
##########
flink-architecture-tests/flink-architecture-tests-base/src/test/java/PredicatesTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.jupiter.api.Test;
+
+import static org.apache.flink.architecture.common.Predicates.getClassSimpleNameFromFqName;
+import static org.assertj.core.api.Assertions.*;
Review Comment:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=53704&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1354896196
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -157,6 +166,35 @@ public static <T> DescribedPredicate<T> exactlyOneOf(
t -> Arrays.stream(other).map(dp -> dp.test(t)).reduce(false, Boolean::logicalXor));
}
+ /**
+ * Extracts the class name from the given fully qualified class name.
+ *
+ * <p>Example:
+ *
+ * <pre>
+ * getClassFromFqName("com.example.MyClass"); // Returns: "MyClass"
+ * </pre>
+ */
+ public static String getClassSimpleNameFromFqName(String fqClassName) {
Review Comment:
Thanks for pointing this out. I changed the approach to handle both cases and added test coverage for this method:
https://github.com/apache/flink/pull/23491/commits/fbea7c9382bd9d3f6a7d80c81e05e8491a137612
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -157,6 +166,35 @@ public static <T> DescribedPredicate<T> exactlyOneOf(
t -> Arrays.stream(other).map(dp -> dp.test(t)).reduce(false, Boolean::logicalXor));
}
+ /**
+ * Extracts the class name from the given fully qualified class name.
+ *
+ * <p>Example:
+ *
+ * <pre>
+ * getClassFromFqName("com.example.MyClass"); // Returns: "MyClass"
+ * </pre>
+ */
+ public static String getClassSimpleNameFromFqName(String fqClassName) {
Review Comment:
Thanks for pointing this out. I changed the approach to handle both cases and added test coverage for this method: https://github.com/apache/flink/pull/23491/commits/fbea7c9382bd9d3f6a7d80c81e05e8491a137612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1357991868
##########
flink-architecture-tests/flink-architecture-tests-base/src/test/java/PredicatesTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.jupiter.api.Test;
+
+import static org.apache.flink.architecture.common.Predicates.getClassSimpleNameFromFqName;
+import static org.assertj.core.api.Assertions.*;
Review Comment:
@zentol please merge this hotfix https://github.com/apache/flink/pull/23522/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "afedulov (via GitHub)" <gi...@apache.org>.
afedulov commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1354883300
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -62,40 +68,42 @@ public static DescribedPredicate<JavaClass> containAnyFieldsInClassHierarchyThat
}
/**
- * Tests that the given field is {@code public static} and of the given type {@code clazz} .
+ * Tests that the given field is {@code public static} and has the fully qualified type name of
+ * {@code fqClassName}.
*
* <p>Attention: changing the description will add a rule into the stored.rules.
*/
- public static DescribedPredicate<JavaField> arePublicStaticOfType(Class<?> clazz) {
Review Comment:
Good point! I ran a script to search for the following methods
```
areFieldOfType
arePublicFinalOfType
arePublicStaticOfType
arePublicStaticFinalOfType
arePublicFinalOfTypeWithAnnotation
arePublicStaticFinalOfTypeWithAnnotation
areStaticFinalOfTypeWithAnnotation
```
across these repositories
```
apache/flink-connector-kafka
apache/flink-connector-cassandra
apache/flink-connector-elasticsearch
apache/flink-connector-rabbitmq
apache/flink-connector-google-cloud-pubsub
apache/flink-connector-pulsar
apache/flink-connector-jdbc
apache/flink-connector-hbase
apache/flink-connector-hive
apache/flink-connector-aws
apache/flink-connector-firehose
apache/flink-connector-kinesis
apache/flink-connector-dynamodb
```
and did not find any usage.
It seems that the question "Does this change in Flink break any connector?" will be a recurring topic with the externalized repos. Having some automated checks is tricky, but feasible:
1) get all the method signature changes in the PR
2) search across the connector repos for usage of the respective classes + methods
The experience I made is that it won't work with GitHub API due to pretty heavy throttling on their side. What do, will checking out all the connector repos in the main Flink CI run work for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]
Posted by "bvarghese1 (via GitHub)" <gi...@apache.org>.
bvarghese1 commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1357730243
##########
flink-architecture-tests/flink-architecture-tests-base/src/test/java/PredicatesTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.jupiter.api.Test;
+
+import static org.apache.flink.architecture.common.Predicates.getClassSimpleNameFromFqName;
+import static org.assertj.core.api.Assertions.*;
Review Comment:
@afedulov I think this `.*` is causing the compile step to fail with a Checkstyle error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org