You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "grgrzybek (via GitHub)" <gi...@apache.org> on 2026/05/05 14:09:32 UTC
[PR] ARTEMIS-5985 Prepare security-oidc example with exhaustive readme.md … [artemis-examples]
grgrzybek opened a new pull request, #29:
URL: https://github.com/apache/artemis-examples/pull/29
…about OAuth2/OIDC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5985 Prepare security-oidc example with exhaustive readme.md … [artemis-examples]
Posted by "grgrzybek (via GitHub)" <gi...@apache.org>.
grgrzybek commented on code in PR #29:
URL: https://github.com/apache/artemis-examples/pull/29#discussion_r3189879291
##########
examples/features/standard/security-oidc/pom.xml:
##########
@@ -0,0 +1,182 @@
+<?xml version='1.0'?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.artemis.examples.broker</groupId>
+ <artifactId>jms-examples</artifactId>
+ <version>2.53.0</version>
Review Comment:
changed - my bad².
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5985 Prepare security-oidc example with exhaustive readme.md … [artemis-examples]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on code in PR #29:
URL: https://github.com/apache/artemis-examples/pull/29#discussion_r3189505296
##########
examples/features/standard/security-oidc/pom.xml:
##########
@@ -0,0 +1,182 @@
+<?xml version='1.0'?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.artemis.examples.broker</groupId>
+ <artifactId>jms-examples</artifactId>
+ <version>2.53.0</version>
Review Comment:
Version should be 2.54.0-SNAPSHOT, thats why the compile job failed on Java 25 (which for nuance is the only one that will compile this as it is using the release profile). Although the jobs normally update the examples versions to match the Artemis version if needed...it checks the existing version at the root, and those matched already, so it didnt update (in part to find issues like this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5985 Prepare security-oidc example with exhaustive readme.md … [artemis-examples]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #29:
URL: https://github.com/apache/artemis-examples/pull/29#discussion_r3190323144
##########
examples/features/standard/security-oidc/readme.md:
##########
@@ -0,0 +1,326 @@
+# JMS Security OpenID Connect Example
+
+If you have not already done so, [prepare the broker distribution](../../../../README.md#getting-started) before running the example.
+
+This example is a fully rewritten version of previous example which worked only with https://www.keycloak.org[Keycloak server].
+Here's a list of important changes and differences:
+
+ - While the example uses Keycloak as an OpenID Connect provider, after minimal configuration changes this example should also work with other providers and there's no need to use any dedicated Keycloak (or other) libraries
+ - This example obtains a JWT access token itself, and no password is sent to Artemis Broker
+ - There are 3 (instead of 2) OpenID Connect _clients_ used (more on that later)
Review Comment:
I don't think this bit is necessary. The `security-keycloak` example can simply be forgotten at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5985 Prepare security-oidc example with exhaustive readme.md … [artemis-examples]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram merged PR #29:
URL: https://github.com/apache/artemis-examples/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-5985 Prepare security-oidc example with exhaustive readme.md … [artemis-examples]
Posted by "grgrzybek (via GitHub)" <gi...@apache.org>.
grgrzybek commented on code in PR #29:
URL: https://github.com/apache/artemis-examples/pull/29#discussion_r3193397193
##########
examples/features/standard/security-oidc/readme.md:
##########
@@ -0,0 +1,326 @@
+# JMS Security OpenID Connect Example
+
+If you have not already done so, [prepare the broker distribution](../../../../README.md#getting-started) before running the example.
+
+This example is a fully rewritten version of previous example which worked only with https://www.keycloak.org[Keycloak server].
+Here's a list of important changes and differences:
+
+ - While the example uses Keycloak as an OpenID Connect provider, after minimal configuration changes this example should also work with other providers and there's no need to use any dedicated Keycloak (or other) libraries
+ - This example obtains a JWT access token itself, and no password is sent to Artemis Broker
+ - There are 3 (instead of 2) OpenID Connect _clients_ used (more on that later)
Review Comment:
sure, I'll remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org