You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/07/07 19:16:31 UTC
[jira] Created: (HARMONY-5899) [classlib][pack200]
ByteCode.equals() can be optimized
[classlib][pack200] ByteCode.equals() can be optimized
------------------------------------------------------
Key: HARMONY-5899
URL: https://issues.apache.org/jira/browse/HARMONY-5899
Project: Harmony
Issue Type: Improvement
Components: Classlib
Affects Versions: 5.0M6
Environment: Pack200 HEAD
Reporter: Andrew Cornwall
Attachments: main.patch
Now that HARMONY-5889 has been incorporated, the .equals() method for ByteCode can be simplified. This leads to some performance increase.
I've also modified the hashCode() method. It now leads to fewer collisions. Now there are as few as if Object.hashCode() were used instead. (I didn't use Object.hashCode() because the abstract hashCode() in ClassFileEntry means I'd have to put a helper method in ClassFileEntry - and if the code in ByteCode is just as fast, why do that?)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5899) [classlib][pack200]
ByteCode.equals() can be optimized
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5899:
-------------------------------------
Assignee: Sian January
> [classlib][pack200] ByteCode.equals() can be optimized
> ------------------------------------------------------
>
> Key: HARMONY-5899
> URL: https://issues.apache.org/jira/browse/HARMONY-5899
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M6
> Environment: Pack200 HEAD
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Attachments: main.patch
>
>
> Now that HARMONY-5889 has been incorporated, the .equals() method for ByteCode can be simplified. This leads to some performance increase.
> I've also modified the hashCode() method. It now leads to fewer collisions. Now there are as few as if Object.hashCode() were used instead. (I didn't use Object.hashCode() because the abstract hashCode() in ClassFileEntry means I'd have to put a helper method in ClassFileEntry - and if the code in ByteCode is just as fast, why do that?)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5899) [classlib][pack200]
ByteCode.equals() can be optimized
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5899:
-------------------------------------
Attachment: main.patch
main.patch code changes for ByteCode
> [classlib][pack200] ByteCode.equals() can be optimized
> ------------------------------------------------------
>
> Key: HARMONY-5899
> URL: https://issues.apache.org/jira/browse/HARMONY-5899
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M6
> Environment: Pack200 HEAD
> Reporter: Andrew Cornwall
> Attachments: main.patch
>
>
> Now that HARMONY-5889 has been incorporated, the .equals() method for ByteCode can be simplified. This leads to some performance increase.
> I've also modified the hashCode() method. It now leads to fewer collisions. Now there are as few as if Object.hashCode() were used instead. (I didn't use Object.hashCode() because the abstract hashCode() in ClassFileEntry means I'd have to put a helper method in ClassFileEntry - and if the code in ByteCode is just as fast, why do that?)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5899) [classlib][pack200] ByteCode.equals()
can be optimized
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison closed HARMONY-5899.
--------------------------------
No response, assuming ok.
> [classlib][pack200] ByteCode.equals() can be optimized
> ------------------------------------------------------
>
> Key: HARMONY-5899
> URL: https://issues.apache.org/jira/browse/HARMONY-5899
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M6
> Environment: Pack200 HEAD
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M7
>
> Attachments: main.patch
>
>
> Now that HARMONY-5889 has been incorporated, the .equals() method for ByteCode can be simplified. This leads to some performance increase.
> I've also modified the hashCode() method. It now leads to fewer collisions. Now there are as few as if Object.hashCode() were used instead. (I didn't use Object.hashCode() because the abstract hashCode() in ClassFileEntry means I'd have to put a helper method in ClassFileEntry - and if the code in ByteCode is just as fast, why do that?)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5899) [classlib][pack200]
ByteCode.equals() can be optimized
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5899.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M7
Patch applied at r674816. Please check that it was applied as you expected.
> [classlib][pack200] ByteCode.equals() can be optimized
> ------------------------------------------------------
>
> Key: HARMONY-5899
> URL: https://issues.apache.org/jira/browse/HARMONY-5899
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M6
> Environment: Pack200 HEAD
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M7
>
> Attachments: main.patch
>
>
> Now that HARMONY-5889 has been incorporated, the .equals() method for ByteCode can be simplified. This leads to some performance increase.
> I've also modified the hashCode() method. It now leads to fewer collisions. Now there are as few as if Object.hashCode() were used instead. (I didn't use Object.hashCode() because the abstract hashCode() in ClassFileEntry means I'd have to put a helper method in ClassFileEntry - and if the code in ByteCode is just as fast, why do that?)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.