[GitHub] [calcite] wenhuitang commented on issue #800: [CALCITE-2460][CALCITE-2459] Add implementation of To_Base64 and From_Base64 to SqlFunctions

[GitBox <gi...@apache.org>]

wenhuitang commented on issue #800: [CALCITE-2460][CALCITE-2459] Add implementation of To_Base64 and  From_Base64 to SqlFunctions
URL: https://github.com/apache/calcite/pull/800#issuecomment-497922600
 
 
   > Also pls address Julian's comments in JIRA(eg BINARY vs VARCHAR)
   
   I have addressed some comments. But as for "TO_BASE64 takes a BINARY or VARBINARY, not a VARCHAR, as argument." , considering Mysql specifies that "Converts the string argument to base-64 encoded form and returns the result as a character string with the connection character set and collation. " https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_to-base64.  I'm not sure if it must change its argument to BINARY or VARBINARY?  So I let TO_BASE64 can take both string and  binary string as argument.  Hope get some advises. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services