[GitHub] [iceberg] amogh-jahagirdar commented on issue #7367: Flaky test: TestParallelIterable

["amogh-jahagirdar (via GitHub)" <gi...@apache.org>]

amogh-jahagirdar commented on issue #7367:
URL: https://github.com/apache/iceberg/issues/7367#issuecomment-1513954239

   Took a look in the code, and have a good idea what the issue is.  There's a race condition, the test relies on the underlying queue in `ParallelIterable` being populated by the time the non empty assertion is run, that's not guaranteed. I verified this theory by adding a sleep before offering to the queue here https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/util/ParallelIterable.java#L70
   
   I'll work on a PR for fixing this test, we should be able to use Awaitility. Ideally we don't even have tests which rely on such timing but looking at the context https://github.com/apache/iceberg/pull/5887 I think it's important to have this specific case since we want to validate the memory is cleared up for engines. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org