You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by lg...@apache.org on 2016/02/21 14:39:58 UTC

[2/2] mina-sshd git commit: Demoted visibility of ExecutorService due to existence of public get/set methods for it

Demoted visibility of ExecutorService due to existence of public get/set methods for it


Project: http://git-wip-us.apache.org/repos/asf/mina-sshd/repo
Commit: http://git-wip-us.apache.org/repos/asf/mina-sshd/commit/d7932443
Tree: http://git-wip-us.apache.org/repos/asf/mina-sshd/tree/d7932443
Diff: http://git-wip-us.apache.org/repos/asf/mina-sshd/diff/d7932443

Branch: refs/heads/master
Commit: d7932443b1d3875610756465c1e3a56ac63e290d
Parents: 5bc4478
Author: Lyor Goldstein <ly...@gmail.com>
Authored: Sun Feb 21 15:40:39 2016 +0200
Committer: Lyor Goldstein <ly...@gmail.com>
Committed: Sun Feb 21 15:40:39 2016 +0200

----------------------------------------------------------------------
 .../java/org/apache/sshd/common/channel/AbstractChannel.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/d7932443/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java b/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java
index afced68..50022ff 100644
--- a/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java
+++ b/sshd-core/src/main/java/org/apache/sshd/common/channel/AbstractChannel.java
@@ -58,7 +58,7 @@ import org.apache.sshd.common.util.io.IoUtils;
 import org.apache.sshd.common.util.threads.ExecutorServiceConfigurer;
 
 /**
- * TODO Add javadoc
+ * Provides common client/server channel functionality
  *
  * @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
  */
@@ -75,8 +75,6 @@ public abstract class AbstractChannel
         Opened, CloseSent, CloseReceived, Closed
     }
 
-    protected ExecutorService executor;
-    protected boolean shutdownExecutor;
     protected ConnectionService service;
     protected final AtomicBoolean initialized = new AtomicBoolean(false);
     protected final AtomicBoolean eofReceived = new AtomicBoolean(false);
@@ -93,6 +91,8 @@ public abstract class AbstractChannel
     private int id = -1;
     private int recipient = -1;
     private Session sessionInstance;
+    private ExecutorService executor;
+    private boolean shutdownExecutor;
 
     private final Window localWindow;
     private final Window remoteWindow;
@@ -379,7 +379,7 @@ public abstract class AbstractChannel
             log.warn("notifyStateChanged({})[{}] {} while signal channel state change: {}",
                      this, hint, e.getClass().getSimpleName(), e.getMessage());
             if (log.isDebugEnabled()) {
-                log.debug("notifyStateChanged(" + this + ")[" + hint + "] channel closed signalling failure details", e);
+                log.debug("notifyStateChanged(" + this + ")[" + hint + "] channel state signalling failure details", e);
             }
         }