You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2021/07/14 10:01:24 UTC
[GitHub] [tomcat] Pingvin235 opened a new pull request #434: Optionally inherit request parameters
Pingvin235 opened a new pull request #434:
URL: https://github.com/apache/tomcat/pull/434
Greetings to All,
the proposed fix makes optional taking requests parameters for internal requests.
Which produced when using JSTL directives `<c:import`.
**Explanation case**
Processing `REQUEST1` with parameters `param1=value11` and `param2=value12`.
Processing forwards to a JSP page, containing internal sub-request:
``` jsp
<c:import url="URL2?param2=value22¶m3=value23"
```
In called `REQUEST2` will be presented:
* `param1=value11`
* `param2=value12¶m2=value22`
* `param3=value23`
Such behavior is not always wanted because of collisions in similar named parameters.
**Solution**
The proposed change has been implemented for a long time ago and successfully tested internally. Would be great to include it in main project. Kindly ask to help with passing through all the requirements for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #434: Optionally inherit request parameters
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-879789821
Such an option would be in direct violation of the Servlet specification. That makes me very hesitant to agree to such a change. The Servlet specification already states that the parameters from the include take precedence. I'd rather add clarification of any ambiguities (if necessary) to the spec and align Tomcat's behaviour with that than add an option for non-compliant behaviour.
Regarding the implementation, I am -1 on the proposed implementation as it is based on an environment variable. If it were implemented, It would need to be a per context configuration attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] Pingvin235 commented on pull request #434: Optionally inherit request parameters
Posted by GitBox <gi...@apache.org>.
Pingvin235 commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-880204596
Thanks for pointing. Assuming this is the conflicting part:
"Parameters specified in the query string used to create the RequestDispatcher take precedence over other parameters of the same name passed to the included servlet."
Perhaps I understand it wrong, but if other parameters are completely excluded, do query string parameters loose their precedence? Actually that we need is to have the query string parameters only. May be you can recommend another way to archive such behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #434: Optionally inherit request parameters
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-979437308
This is not going to be applied. The users mailing list is the place to discuss your requirement and possible solutions.
As a starting point, how about ensuring the target servlets take only the first value for any parameter. Then you can rely on the precedence rules in the specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #434: Optionally inherit request parameters
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #434:
URL: https://github.com/apache/tomcat/pull/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] Pingvin235 commented on pull request #434: Optionally inherit request parameters
Posted by GitBox <gi...@apache.org>.
Pingvin235 commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-880041227
Could you please point me the place in the specification, describing that behavior? For 4.0 could found only section 9.3 regarding includes, but didn't notice anything about parameters inheritance / precedence..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] Pingvin235 commented on pull request #434: Optionally inherit request parameters
Posted by GitBox <gi...@apache.org>.
Pingvin235 commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-880042757
> Regarding the implementation, I am -1 on the proposed implementation as it is based on an environment variable. If it were implemented, It would need to be a per context configuration attribute.
Can do it this way of course case this option is in principle allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #434: Optionally inherit request parameters
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-880066207
You want the last paragraph of section 9.1.1. A RequestDispatcher is what performs the include or forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org