You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/30 13:07:00 UTC

[GitHub] [yunikorn-core] craigcondit commented on pull request #457: [YUNIKORN-1430] change go version check in Makefile

craigcondit commented on PR #457:
URL: https://github.com/apache/yunikorn-core/pull/457#issuecomment-1332126304

   > Do you mean that if an error occurs during the `go build` phase, `Build should be run with at least go $(MOD_VERSION) or later, found $(GO_VERSION)` will be displayed?
   
   No, the build fails because the license check GitHub action comes before the step which installs the correct version of go. You need to update the GitHub workflow file to reverse this order. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org