You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Jacob Champion <ch...@gmail.com> on 2016/05/25 21:05:06 UTC

[PATCH] Fix the Windows build for trunk

Hi all,

For your consideration, three patches to trunk to fix the CMake build on 
Windows:

1) APR_DECLARE() the new apr_cstr API so it gets exported correctly.
2) Fix a "pmutex" variable name typo introduced in r1733775 as part of
    the apr_os_proc_mutex_* change.
3) Use CMake generator expressions to locate PDBs instead of assuming
    that they are always built in the top-level binary directory. Multi-
    configuration generators (like Visual Studio) put the PDBs into
    different subdirectories depending on the build type.

--Jacob

Re: [PATCH] Fix the Windows build for trunk

Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 25 May 2016 at 23:05, Jacob Champion <ch...@gmail.com> wrote:
> Hi all,
>
> For your consideration, three patches to trunk to fix the CMake build on
> Windows:
>
> 1) APR_DECLARE() the new apr_cstr API so it gets exported correctly.
As far I understand APR_DECLARE() should be added to both function
declaration and implementation. I've posted different patch to fix
this [1]

 [1] https://lists.apache.org/thread.html/d91d91a8b9a17d0275a55733d2eeece7d86e24ada60ac348ec55c3c3@%3Cdev.apr.apache.org%3E

-- 
Ivan Zhakov