[jira] [Updated] (STORM-2568) Wrong configuration 'groupid' to get lag for new kafka spout

["Haewan Jeong (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haewan Jeong updated STORM-2568:
--------------------------------
    Description: 
Hello

I've tried to use storm-kafka-monitor, and it works fine on command line If I changed 'toollib/storm-kafka-monitor-*.jar' to 'toollib/storm-kafka-monitor-1.1.0.jar'.

but it gives empty result when I call below api.
{code}
/api/v1/topology/:id/lag
...

{
"MySpoutName": {
"spoutLagResult": {},
"spoutId": "MySpoutName",
"spoutType": "KAFKA"
}
}
{code}

I think that needs to fix "groupid" to "group.id" in TopologySpoutLag.java

{code}
package org.apache.storm.utils;
public class TopologySpoutLag {
...
commands.add((String)jsonConf.get(configKeyPrefix + "groupid"));
{code}


{code}
package org.apache.storm.kafka.spout;
public class KafkaSpoutConfig<K, V> implements Serializable {
...
public String getConsumerGroupId() {
        return (String)this.kafkaProps.get("group.id");
    }
...
        public KafkaSpoutConfig.Builder<K, V> setGroupId(String id) {
            return this.setProp("group.id", id);
        }
{code}


  was:
Hello

I've tried to use storm-kafka-monitor, and it works fine on command line If I changed 'toollib/storm-kafka-monitor-*.jar' to 'toollib/storm-kafka-monitor-1.1.0.jar'.

but it gives empty result when I call below api.
{code}
/api/v1/topology/:id/lag
...

{
"MySpoutName": {
"spoutLagResult": {},
"spoutId": "MySpoutName",
"spoutType": "KAFKA"
}
}
{code}

I think need to fix "groupid" to "group.id" in TopologySpoutLag.java

{code}
package org.apache.storm.utils;
public class TopologySpoutLag {
...
commands.add((String)jsonConf.get(configKeyPrefix + "groupid"));
{code}


{code}
package org.apache.storm.kafka.spout;
public class KafkaSpoutConfig<K, V> implements Serializable {
...
public String getConsumerGroupId() {
        return (String)this.kafkaProps.get("group.id");
    }
...
        public KafkaSpoutConfig.Builder<K, V> setGroupId(String id) {
            return this.setProp("group.id", id);
        }
{code}



> Wrong configuration 'groupid' to get lag for new kafka spout
> ------------------------------------------------------------
>
>                 Key: STORM-2568
>                 URL: https://issues.apache.org/jira/browse/STORM-2568
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 1.1.0
>            Reporter: Haewan Jeong
>
> Hello
> I've tried to use storm-kafka-monitor, and it works fine on command line If I changed 'toollib/storm-kafka-monitor-*.jar' to 'toollib/storm-kafka-monitor-1.1.0.jar'.
> but it gives empty result when I call below api.
> {code}
> /api/v1/topology/:id/lag
> ...
> {
> "MySpoutName": {
> "spoutLagResult": {},
> "spoutId": "MySpoutName",
> "spoutType": "KAFKA"
> }
> }
> {code}
> I think that needs to fix "groupid" to "group.id" in TopologySpoutLag.java
> {code}
> package org.apache.storm.utils;
> public class TopologySpoutLag {
> ...
> commands.add((String)jsonConf.get(configKeyPrefix + "groupid"));
> {code}
> {code}
> package org.apache.storm.kafka.spout;
> public class KafkaSpoutConfig<K, V> implements Serializable {
> ...
> public String getConsumerGroupId() {
>         return (String)this.kafkaProps.get("group.id");
>     }
> ...
>         public KafkaSpoutConfig.Builder<K, V> setGroupId(String id) {
>             return this.setProp("group.id", id);
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)