[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service

[GitBox <gi...@apache.org>]

gy09535 edited a comment on pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891


   > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one?
   
   For combined into one I think the aliyun has some special config, we should has different plugin to config it and I reference  tcp logger plugin to implement it, I think I can refactor tcp logger and sls logger plugin , change the common code into one module, For system log I think  some code  is duplicate , for example the batch processor has [retry]( https://github.com/apache/apisix/blob/master/apisix/plugins/syslog.lua#L179) the "resty.logger.socket" also has [retry](https://github.com/apache/apisix/blob/master/apisix/plugins/syslog.lua#L96) etc. so I prefer use cosocket .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org