[GitHub] [activemq-artemis] jsmucr edited a comment on pull request #3177: ARTEMIS-2801 Fix ByteUtil.getHumanReadableByteCount() giving inconsistent results

[GitBox <gi...@apache.org>]

jsmucr edited a comment on pull request #3177:
URL: https://github.com/apache/activemq-artemis/pull/3177#issuecomment-643057629


   @jbertram I too thought about that but for me it seemed a bit tough and not very transparent to cover various locales in a test. What I mean is that you'd either have to enumerate the possible values, or compare the method return value to something you cannot really see at the moment of testing.
   Maybe I'm not fully awake yet but wouldn't that mean to pretty much copy-paste the method functionality to the test?
   
   EDIT: I see what you did in #3178. It avoids the other differences such as grouping which is ok as long as it returns kB instead of KiB. Is that correct? I mean, I know the difference. But is that what the regular user would expect?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org