You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2016/03/29 17:44:24 UTC
[GitHub] brooklyn-dist pull request: remove the properties section from thi...
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-dist/pull/27
remove the properties section from this file
they are all pulled in from the parent (brooklyn-server/pom.xml, except for jackson which we don't want to declare as we don't use it.
sidebar comment, i now tend to the opinion that we *don't* want this. downstream projects should define their own workflow. the main value is ensuring versions are compatible but that is something we can/should handle a different way. (simple way, just by running the license-audit plugin and eyeball anything with multiple versions...)
/cc @neykov @aledsage @hzbarcea wdyt?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-dist simplify-downstream-parent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit e8395730159c22759e14044e61836fdc4f931739
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2016-03-29T15:41:28Z
remove the properties section from this file. they are all pulled in from the parent (brooklyn-server/pom.xml).
(except for jackson which we don't want to declare as we don't use it.)
sidebar comment, i now tend to the opinion that we *don't* want this. downstream projects should define their own workflow.
the main value is ensuring versions are compatible but that is something we can/should handle a different way.
(simple way, just by running the license-audit plugin and eyeball anything with multiple versions...)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: remove the properties section from thi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: remove the properties section from thi...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/27#issuecomment-202972549
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---