You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/05/12 09:10:22 UTC
[GitHub] [yunikorn-k8shim] pbacsko opened a new pull request, #421: [YUNIKORN-1197] Placeholders are immediately replaced during recovery
pbacsko opened a new pull request, #421:
URL: https://github.com/apache/yunikorn-k8shim/pull/421
### What is this PR for?
In certain cases, running placeholders are immediately replaced if Yunikorn is restarted. It's because the `Application` in on the shim side does not stay in `Reserving` state, but transitions to `Running`. This causes resource asks to be added and the scheduler replaces the placeholder pods.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1197
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #421: [YUNIKORN-1197] Placeholders are immediately replaced during recovery
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #421:
URL: https://github.com/apache/yunikorn-k8shim/pull/421#issuecomment-1124736316
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/421?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#421](https://codecov.io/gh/apache/yunikorn-k8shim/pull/421?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (10d03ba) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/7c8684b46152a1e5701e81a07ad49ed0bb974733?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8684b) will **decrease** coverage by `0.08%`.
> The diff coverage is `42.10%`.
```diff
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
- Coverage 65.44% 65.36% -0.08%
==========================================
Files 40 40
Lines 6389 6406 +17
==========================================
+ Hits 4181 4187 +6
- Misses 2045 2053 +8
- Partials 163 166 +3
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `85.45% <22.22%> (-5.73%)` | :arrow_down: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `72.34% <60.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/421?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/421?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8684b...10d03ba](https://codecov.io/gh/apache/yunikorn-k8shim/pull/421?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko closed pull request #421: [YUNIKORN-1197] Placeholders are immediately replaced during recovery
Posted by GitBox <gi...@apache.org>.
pbacsko closed pull request #421: [YUNIKORN-1197] Placeholders are immediately replaced during recovery
URL: https://github.com/apache/yunikorn-k8shim/pull/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org