You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/09 13:36:28 UTC

[GitHub] tillrohrmann commented on a change in pull request #7441: [FLINK-11156][tests, runtime] Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9

tillrohrmann commented on a change in pull request #7441: [FLINK-11156][tests, runtime] Reconcile ZooKeeperCompletedCheckpointStoreMockitoTest with JDK 9
URL: https://github.com/apache/flink/pull/7441#discussion_r246381058
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
 ##########
 @@ -98,43 +92,23 @@
 	 *                                       least 1). Adding more checkpoints than this results
 	 *                                       in older checkpoints being discarded. On recovery,
 	 *                                       we will only start with a single checkpoint.
-	 * @param client                         The Curator ZooKeeper client
-	 * @param checkpointsPath                The ZooKeeper path for the checkpoints (needs to
-	 *                                       start with a '/')
-	 * @param stateStorage                   State storage to be used to persist the completed
-	 *                                       checkpoint
 
 Review comment:
   new parameter JavaDocs are missing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services