You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@buildr.apache.org by Antoine Toulme <an...@lunar-ocean.com> on 2010/04/10 19:27:26 UTC

Manifest packaging: not closing the Tempfile ?

Line 181 of packaging.rb, we don't close the Tempfile that represents the
MANIFEST.MF.
I understand that we need to keep the file, but we could maybe close it with
unlink set to false ?
That sounds like an open file leak to me otherwise.

Should I file a bug ?

Antoine

Re: Manifest packaging: not closing the Tempfile ?

Posted by Antoine Toulme <an...@lunar-ocean.com>.

Filing https://issues.apache.org/jira/browse/BUILDR-423 for it.

On Sat, Apr 10, 2010 at 21:32, Alex Boisvert <al...@gmail.com>wrote:

> On Sat, Apr 10, 2010 at 10:27 AM, Antoine Toulme <an...@lunar-ocean.com>wrote:
>
>> Line 181 of packaging.rb, we don't close the Tempfile that represents the
>> MANIFEST.MF.
>> I understand that we need to keep the file, but we could maybe close it
>> with
>> unlink set to false ?
>> That sounds like an open file leak to me otherwise.
>>
>
> Yes, it would be better to close the file.
>
> alex
>
>

Re: Manifest packaging: not closing the Tempfile ?

Posted by Alex Boisvert <al...@gmail.com>.

On Sat, Apr 10, 2010 at 10:27 AM, Antoine Toulme <an...@lunar-ocean.com>wrote:

> Line 181 of packaging.rb, we don't close the Tempfile that represents the
> MANIFEST.MF.
> I understand that we need to keep the file, but we could maybe close it
> with
> unlink set to false ?
> That sounds like an open file leak to me otherwise.
>

Yes, it would be better to close the file.

alex